From: Daniel Borkmann <dborkman@redhat.com>
To: Thomas Graf <tgraf@suug.ch>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
Simon Horman <horms@verge.net.au>,
Daniel Borkmann <dborkmann@redhat.com>
Subject: Re: [PATCH net-next v2] pktgen: Fix position of ip and udp header
Date: Tue, 04 Jun 2013 00:03:00 +0200 [thread overview]
Message-ID: <51AD1294.8090604@redhat.com> (raw)
In-Reply-To: <08fe3153790311fbd98b1570a3e8134ddaac58a3.1370296008.git.tgraf@suug.ch>
On 06/03/2013 11:49 PM, Thomas Graf wrote:
> skb_set_network_header() expects an offset based on the data pointer
> whereas skb_tail_offset() also includes the headroom. This resulted
> in the ip header being written in a wrong location.
>
> Use return values of skb_put() directly and rely on skb->len to
> set mac, network, and transport header.
>
> Cc: Simon Horman <horms@verge.net.au>
> Cc: Daniel Borkmann <dborkmann@redhat.com>
> Assisted-by: Daniel Borkmann <dborkmann@redhat.com>
> Signed-off-by: Thomas Graf <tgraf@suug.ch>
Thanks !
Acked-by: Daniel Borkmann <dborkmann@redhat.com>
next prev parent reply other threads:[~2013-06-03 22:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 21:49 [PATCH net-next v2] pktgen: Fix position of ip and udp header Thomas Graf
2013-06-03 22:03 ` Daniel Borkmann [this message]
2013-06-05 0:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AD1294.8090604@redhat.com \
--to=dborkman@redhat.com \
--cc=davem@davemloft.net \
--cc=dborkmann@redhat.com \
--cc=horms@verge.net.au \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.