From: Stephen Warren <swarren@wwwdotorg.org>
To: Arend van Spriel <arend@broadcom.com>,
"John W. Linville" <linville@tuxdriver.com>
Cc: Hante Meuleman <meuleman@broadcom.com>,
"'linux-wireless@vger.kernel.org'"
<linux-wireless@vger.kernel.org>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>
Subject: Regression in 9390ace brcmfmac: free net device when registration fails
Date: Mon, 03 Jun 2013 16:56:34 -0600 [thread overview]
Message-ID: <51AD1F22.2080004@wwwdotorg.org> (raw)
(John, note that this commit is part of the pull request you sent to
Dave today)
Arend,
Commit 9390ace "brcmfmac: free net device when registration fails"
causes a regression.
I had the BCM4330 firmware present in my root fs, whereas my HW is a
BCM4329. With this patch applied, I get a kernel panic on boot. With it
reverted, I see that no issues of that nature. This is true in
next-20130531 (and also 5/30 and 6/1 but not earlier). A bisect of
Linus's tree followed by a merge of John's wireless pull request from
today pointed at this same commit.
Related: Since the two hardware require different firmware, I wonder why
the driver doesn't use a firmware filename that encodes the HW device ID
instead of using the same name for all HW. This means that when I move
my SD card between development systems, I have to copy different
firmware over the top. That's a little painful...
next reply other threads:[~2013-06-03 22:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 22:56 Stephen Warren [this message]
[not found] ` <51AD1F22.2080004-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-06-04 12:58 ` Regression in 9390ace brcmfmac: free net device when registration fails Arend van Spriel
2013-06-04 12:58 ` Arend van Spriel
2013-06-06 21:10 ` Arend van Spriel
2013-06-06 21:36 ` Stephen Warren
2013-06-12 21:19 ` Stephen Warren
2013-06-13 8:09 ` Arend van Spriel
2013-06-13 17:32 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AD1F22.2080004@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=arend@broadcom.com \
--cc=linux-next@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=meuleman@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.