From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40822) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uji3A-0001nn-J4 for qemu-devel@nongnu.org; Mon, 03 Jun 2013 23:36:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uji39-0006uy-Mv for qemu-devel@nongnu.org; Mon, 03 Jun 2013 23:36:44 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:43892) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uji39-0006ut-F5 for qemu-devel@nongnu.org; Mon, 03 Jun 2013 23:36:43 -0400 Message-ID: <51AD60C7.4040804@msgid.tls.msk.ru> Date: Tue, 04 Jun 2013 07:36:39 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <1370251243-20352-1-git-send-email-mjt@msgid.tls.msk.ru> <51AC8D38.90205@redhat.com> <51AC8F21.3070109@msgid.tls.msk.ru> <51ACDE38.6050708@redhat.com> In-Reply-To: <51ACDE38.6050708@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH trivial] acpi: actually require either data= or file= for -acpitable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: qemu-devel@nongnu.org 03.06.2013 22:19, Laszlo Ersek wrote: > On 06/03/13 14:42, Michael Tokarev wrote: [] >> This function has another error -- if the file specified >> (either for data= or file=) can't be read, it happily >> continues instead of erroring out. _That_ is the bug >> I tried to hunt but catched something else entirely ;) >> >> Will send a real fix later today... :) > > Please CC me; IIRC I sought to test this code reasonably deeply when I > wrote / transformed it. I'm curious. It looks like I used wrong version when encountered this bug. I can't reproduce it with current source, and by inspecting the source I don't see any issues with that either. It made me to find a non-existing bug earlier, apparently. Thanks! /mjt