From: Bart Van Assche <bvanassche@acm.org>
To: gurinder.shergill@hp.com
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] make dev_loss_tmo checks uniform across drivers
Date: Tue, 04 Jun 2013 08:54:02 +0200 [thread overview]
Message-ID: <51AD8F0A.9050007@acm.org> (raw)
In-Reply-To: <1370283919-11884-1-git-send-email-gurinder.shergill@hp.com>
On 06/03/13 20:25, gurinder.shergill@hp.com wrote:
> The dev_loss_tmo parameter controls how long the FC transport layer
> insulates a loss of a remote port. It is defined to be between 1 and
> SCSI_DEVICE_BLOCK_MAX_TIMEOUT (600). Different drivers do slightly different
> checks when passed this parameter. This patch makes the dev_loss_tmo setting
> uniform across all the drivers by pulling the common logic into the
> transport layer function which is responsible for invoking the driver
> provided callouts.
>
> In addition, this patch also fixes a issue (see below), where dev_loss_tmo
> could end up with a value more than SCSI_DEVICE_BLOCK_MAX_TIMEOUT when
> fast_io_fail_tmo is enabled and then disabled. The change is to never
> allow dev_loss_tmo to be out of its defined range. And, once that is a
> given, then fast_io_fail_tmo can be capped by dev_loss_tmo.
Hello Sunny,
As far as I know some users set fast_io_fail_tmo such that dev_loss_tmo
can be set to a very large value in order to prevent that the SCSI host
number changes. Sorry but I'm not sure it's a good idea to remove that
functionality.
Bart.
next prev parent reply other threads:[~2013-06-04 6:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 18:25 [PATCH] make dev_loss_tmo checks uniform across drivers gurinder.shergill
2013-06-04 6:54 ` Bart Van Assche [this message]
2013-06-05 22:29 ` Shergill, Gurinder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AD8F0A.9050007@acm.org \
--to=bvanassche@acm.org \
--cc=gurinder.shergill@hp.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.