From: Andrew Cooper <andrew.cooper3@citrix.com>
To: George Dunlap <George.Dunlap@eu.citrix.com>
Cc: "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xen.org>
Subject: Re: AMD/IOMMU: revert "SR56x0 Erratum 64 - Reset all head & tail pointers"
Date: Tue, 4 Jun 2013 10:30:40 +0100 [thread overview]
Message-ID: <51ADB3C0.8050608@citrix.com> (raw)
In-Reply-To: <CAFLBxZbCN-KJT6pOipwO_-swjB0PFtnpu62KM-Pkqk1hZrnekg@mail.gmail.com>
On 04/06/13 10:24, George Dunlap wrote:
> On Mon, Jun 3, 2013 at 10:43 AM, Andrew Cooper
> <andrew.cooper3@citrix.com> wrote:
>> On 03/06/13 08:12, Jan Beulich wrote:
>>> The code this patch added is redundant with already present code in
>>> set_iommu_{command_buffer,{event,ppr}_log}_control(). Just switch those
>>> ones from using writel() to writeq() for consistency.
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> Yikes - I clearly didn't do a good job looking to see whether this issue
>> had already been addressed.
>>
>> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
> You couldn't make this an "Acked-by", could you?
>
> -George
I could do that, but as I am not a maintainer, I was under the
impression that reviewed-by was my preferred way of saying "I think this
is sensible".
~Andrew
next prev parent reply other threads:[~2013-06-04 9:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 7:12 AMD/IOMMU: revert "SR56x0 Erratum 64 - Reset all head & tail pointers" Jan Beulich
2013-06-03 9:43 ` Andrew Cooper
2013-06-04 4:41 ` Suravee Suthikulpanit
2013-06-04 6:33 ` Jan Beulich
2013-06-05 6:53 ` Suravee Suthikulpanit
2013-06-04 9:24 ` George Dunlap
2013-06-04 9:30 ` Andrew Cooper [this message]
2013-06-04 9:38 ` George Dunlap
2013-06-04 9:53 ` Ian Campbell
2013-06-04 9:56 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51ADB3C0.8050608@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.