Re: [LTP] [PATCH] shmget/shmget01.c: cleanup and attach SHM_NORESERVE to shmflg

[DAN LI <li.dan@cn.fujitsu.com>]

On 06/04/2013 03:30 PM, Caspar Zhang wrote:
> On 06/04/2013 04:47 AM, Jan Stancek wrote:
>>>>>>> > >>>>
>>>>>>> > >>>>3. Add SHM_NORESERVE to shmflg to test
>>>>>> > >>>
>>>>>> > >>>Can you add some description why you are adding this flag?
>>>>> > >>
>>>>> > >>Actually, we are trying to complete test cases and expand
>>>>> > >>the test scope of LTP.
>>>>> > >>
>>>>> > >>So, it is just for completeness of this case.
>>>> > >
>>>> > >My concern here is:
>>>> > >So if we add this flag, we cover SHM_NORESERVE path.
>>>> > >Do we have a testcase which still covers current non-SHM_NORESERVE path?
>>> >
>>> >Hi Jan,
>>> >
>>> >Sorry for the late reply.:)
>>> >
>>> >In my opinion, SHM_NORESERVE is an independent feature of others and should
>>> >have
>>> >no effect on them, so we do not need a non-SHM_NORESERVE path.
>>> >They are like two branches of a river, one branch can do nothing on the other
>>> >one,
>>> >but if either of them goes wrong, the river will get feedback.
>> Presence of that flag has some effect, absence has different one.
>> To follow up on river metaphore, Are crocodiles in this river?
>>
>> Anyway, we cover that path in other testcases, so unless
>> someone else objects, I'm OK with adding that flag.
>>
> 
> Crocodile spotted:
> 
> in fact in this patch, SHM_NORESERVE doesn't get fully tested. from the man page:
> 
>     SHM_NORESERVE (since Linux 2.6.15)
>         [snip]When swap space is not reserved one might get SIGSEGV upon a write if no physical memory is available. [snip]
> 
> We could design such a new testcase if we really want to cover the SHM_NORESERVE branch of river (and the RESERVE branch
> as well) by set the flag and fill the memory, check the result to see if a SIGSEGV is triggered.
> 
> Thoughts?

Do you have any idea about how or what i can use to fill memory and keep away from the OOM-kill,
when trigger this SIGSEGV? :)

Regards,
DAN LI

> 
> Caspar
> 



------------------------------------------------------------------------------
How ServiceNow helps IT people transform IT departments:
1. A cloud service to automate IT design, transition and operations
2. Dashboards that offer high-level views of enterprise services
3. A single system of record for all IT processes
http://p.sf.net/sfu/servicenow-d2d-j
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list