From: Christian Riesch <christian.riesch@omicron.at>
To: dedekind1@gmail.com
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH v2 1/4] mtd: cfi_cmdset_0002: Add support for reading OTP
Date: Tue, 04 Jun 2013 13:30:50 +0200 [thread overview]
Message-ID: <51ADCFEA.3060605@omicron.at> (raw)
In-Reply-To: <1370252414.21714.29.camel@sauron.fi.intel.com>
On 2013-06-03 11:40, Artem Bityutskiy wrote:
> On Wed, 2013-05-29 at 16:36 +0200, Christian Riesch wrote:
>>> But retlen is where you return the amount of bytes you actually
>> wrote.
>>> The return code is either 0 or a negative error code number. This is
>>> what we do in mtd_write() and I'd expect the OTP functions to be
>>> consistent.
>>
>> Unlike mtd_write, mtd->_get_fact_prot_info (which is a pointer to
>> cfi_amdstd_get_fact_prot_info here) does not have a retlen parameter.
>> Do
>> you suggest to change this?
>
> Yes, I would suggest this.
>
Ok, I will prepare a patch for this.
Thanks, Christian
next prev parent reply other threads:[~2013-06-04 11:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1367003430-24584-1-git-send-email-christian.riesch@omicron.at>
2013-04-26 19:10 ` [PATCH v2 1/4] mtd: cfi_cmdset_0002: Add support for reading OTP Christian Riesch
2013-05-29 7:11 ` Artem Bityutskiy
2013-05-29 12:54 ` Christian Riesch
2013-05-29 13:53 ` Artem Bityutskiy
2013-05-29 14:36 ` Christian Riesch
2013-06-03 9:40 ` Artem Bityutskiy
2013-06-04 11:30 ` Christian Riesch [this message]
2013-04-26 19:10 ` [PATCH v2 2/4] mtd: cfi_cmdset_0002: Invalidate cache after entering/exiting OTP memory Christian Riesch
2013-04-26 19:10 ` [PATCH v2 3/4] mtd: cfi_cmdset_0002: Add support for writing " Christian Riesch
2013-04-26 19:10 ` [PATCH v2 4/4] mtd: cfi_cmdset_0002: Add support for locking " Christian Riesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51ADCFEA.3060605@omicron.at \
--to=christian.riesch@omicron.at \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.