All of lore.kernel.org
 help / color / mirror / Atom feed
From: Diana Crisan <dcrisan@flexiant.com>
To: Alex Bligh <alex@alex.org.uk>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
	xen-devel@lists.xen.org, Keir Fraser <keir@xen.org>,
	Jan Beulich <jbeulich@suse.com>,
	Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH v2] x86/vtsc: update vcpu_time in hvm_set_guest_time
Date: Tue, 04 Jun 2013 17:38:47 +0100	[thread overview]
Message-ID: <51AE1817.5010309@flexiant.com> (raw)
In-Reply-To: <B5F50B9A76AD8759FC41EFB4@nimrod.local>

On 04/06/13 14:59, Alex Bligh wrote:
>
>
> --On 4 June 2013 14:09:31 +0100 George Dunlap 
> <george.dunlap@eu.citrix.com> wrote:
>
>> On 06/04/2013 01:49 PM, Roger Pau Monne wrote:
>>> When using a vtsc, hvm_set_guest_time changes hvm_vcpu.stime_offset,
>>> which is used in the vcpu time structure to calculate the
>>> tsc_timestamp, so after updating stime_offset we need to propagate the
>>> change to vcpu_time in order for the guest to get the right time if
>>> using the PV clock.
>>>
>>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>>> Cc: Keir Fraser <keir@xen.org>
>>> Cc: Jan Beulich <jbeulich@suse.com>
>>> Cc: George Dunlap <george.dunlap@eu.citrix.com>
>>
>> Reviewed-by: George Dunlap <george.dunlap@eu.citrix.com>
>>
>> Diana / Alex, want to give this one a spin?
>
> We will do. If it works we will test a 4.2.2 backport too.
>
I have tested patch-v2 with xen4.3 and it did not get a clock stuck yet 
across mutiple migrations between hosts (i.e. not localhost). I have 
patched in v3 and will do some further stress testing tomorrow. Once it 
works I will also test a backport to 4.2.2 and also give an update.

Thanks,
Diana


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2013-06-04 16:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-04 12:49 [PATCH v2] x86/vtsc: update vcpu_time in hvm_set_guest_time Roger Pau Monne
2013-06-04 13:09 ` George Dunlap
2013-06-04 13:59   ` Alex Bligh
2013-06-04 16:38     ` Diana Crisan [this message]
2013-06-04 13:47 ` Jan Beulich
2013-06-04 16:27   ` George Dunlap
2013-06-04 16:33     ` Jan Beulich
2013-06-04 15:25 ` George Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51AE1817.5010309@flexiant.com \
    --to=dcrisan@flexiant.com \
    --cc=alex@alex.org.uk \
    --cc=george.dunlap@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=keir@xen.org \
    --cc=roger.pau@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.