From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: Xen on ARM GIC setup Date: Tue, 4 Jun 2013 22:23:32 +0100 Message-ID: <51AE5AD4.5010100@citrix.com> References: <51AE5A5E.4060409@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <51AE5A5E.4060409@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Sander Bogaert Cc: xen-devel List-Id: xen-devel@lists.xenproject.org I forgot to cc Sander. On 06/04/2013 10:21 PM, Julien Grall wrote: > On 06/04/2013 08:42 PM, Sander Bogaert wrote: > >> Hi, > > Hi, > >> I was going over this part of the gic setup code ( gic.c:gic_dist_init ): >> >> type = GICD[GICD_TYPER]; >> gic.lines = 32 * (type & GICD_TYPE_LINES); >> .... >> /* Disable all global interrupts */ >> for ( i = 32; i < gic.lines; i += 32 ) >> GICD[GICD_ICENABLER + i / 32] = (uint32_t)~0ul; > > It seems you have an old tree :). A commit (2f2a3e31) was pushed at the > end of april to fix this issue. > > Cheers, >