Re: [PATCH 1/3 net-next] bcm63xx_enet: implement reset autoneg ethtool callback

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 06/05/2013 01:41 AM, Florian Fainelli wrote:

    Why are you not posting to netdev@vger.kernel.org?

> From: Maxime Bizon <mbizon@freebox.fr>
>
> Implement the rset_nway ethtool callback which uses libphy generic
> autonegotiation restart function.
>
> Signed-off-by: Maxime Bizon <mbizon@freebox.fr>
> ---
>   drivers/net/ethernet/broadcom/bcm63xx_enet.c |   15 +++++++++++++++
>   1 file changed, 15 insertions(+)
>
> diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
> index e46466c..bc1a994 100644
> --- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c
> +++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
> @@ -1328,6 +1328,20 @@ static void bcm_enet_get_ethtool_stats(struct net_device *netdev,
>   	mutex_unlock(&priv->mib_update_lock);
>   }
>   
> +static int bcm_enet_nway_reset(struct net_device *dev)
> +{
> +	struct bcm_enet_priv *priv;
> +
> +	priv = netdev_priv(dev);

     Strange, why not do it in the initializer?

WBR, Sergei