All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Wang <wangyun@linux.vnet.ibm.com>
To: Tejun Heo <tj@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/3] workqueue: code refine/clean for workqueue
Date: Wed, 05 Jun 2013 15:39:35 +0800	[thread overview]
Message-ID: <51AEEB37.1070403@linux.vnet.ibm.com> (raw)
In-Reply-To: <51AEE452.8080605@linux.vnet.ibm.com>

On 06/05/2013 03:10 PM, Michael Wang wrote:
> Code refine/clean patch set for workqueue.
> 
> Michael Wang (3):
> 	[PATCH 1/3] workqueue: move the internal helper from .h to .c
> 	[PATCH 2/3] workqueue: remove the unused helper in .h
> 	[PATCH 3/3] workqueue: add a check point in pwq_activate_delayed_work()

Hi, Tejun

Sounds like I failed to grasp the essentials of the way we maintain
workqueue :(

These are just self opinion I got during the review, please ignore them
if they will cause trouble to your maintain work :)

Regards,
Michael Wang

> 
> ---
>  b/include/linux/workqueue.h |    5 -----
>  b/kernel/workqueue.c        |    5 +++++
>  include/linux/workqueue.h   |   27 ---------------------------
>  kernel/workqueue.c          |    6 +++---
>  4 files changed, 8 insertions(+), 35 deletions(-)
> 


      parent reply	other threads:[~2013-06-05  7:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-05  7:10 [PATCH 0/3] workqueue: code refine/clean for workqueue Michael Wang
2013-06-05  7:10 ` [PATCH 1/3] workqueue: move the internal helper from .h to .c Michael Wang
2013-06-05  7:19   ` Tejun Heo
2013-06-05  7:11 ` [PATCH 2/3] workqueue: remove the unused helper in .h Michael Wang
2013-06-05  7:24   ` Tejun Heo
2013-06-05  7:11 ` [PATCH 3/3] workqueue: add a check point in pwq_activate_delayed_work() Michael Wang
2013-06-05  7:17   ` Tejun Heo
2013-06-05  7:14 ` [PATCH 4/3] workqueue: code refine in wqattrs_equal() Michael Wang
2013-06-05  7:21   ` Tejun Heo
2013-06-05  7:15 ` [PATCH 0/3] workqueue: code refine/clean for workqueue Michael Wang
2013-06-05  7:39 ` Michael Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51AEEB37.1070403@linux.vnet.ibm.com \
    --to=wangyun@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.