From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] Revert "irq: Add extra debugging to help
 track down why an assertion is failing"
Date: Wed, 5 Jun 2013 10:19:37 +0100
Message-ID: <51AF02A9.2090408@citrix.com>
References: <51AF1D7302000078000DB5E0@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <51AF1D7302000078000DB5E0@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: "Keir (Xen.org)" <keir@xen.org>, xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 05/06/13 10:13, Jan Beulich wrote:
> This reverts commits 2ae8b9173fb2388af6514c730d620ed5f450bc34 and
> 98e10364bde098e12104caa4f566b17d05f8b791.
>
> This was never reported to be hit, and we assume to have taken care of
> the problem by excluding legacy IRQs from the IRQ move cleanup logic.
>
> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

>
> --- a/xen/arch/x86/irq.c
> +++ b/xen/arch/x86/irq.c
> @@ -624,8 +624,6 @@ void move_native_irq(struct irq_desc *de
>      desc->handler->enable(desc);
>  }
>  
> -static void dump_irqs(unsigned char key);
> -
>  void irq_move_cleanup_interrupt(struct cpu_user_regs *regs)
>  {
>      unsigned vector, me;
> @@ -687,19 +685,7 @@ void irq_move_cleanup_interrupt(struct c
>  
>              if ( desc->arch.used_vectors )
>              {
> -                if ( unlikely(!test_bit(vector, desc->arch.used_vectors)) )
> -                {
> -                    spin_unlock(&desc->lock);
> -                    bitmap_scnlistprintf(keyhandler_scratch,
> -                                         sizeof(keyhandler_scratch),
> -                                         desc->arch.used_vectors->_bits,
> -                                         NR_VECTORS);
> -                    printk("*** IRQ BUG found ***\n"
> -                           "CPU%d -Testing vector %d from bitmap %s\n",
> -                           me, vector, keyhandler_scratch);
> -                    dump_irqs('i');
> -                    BUG();
> -                }
> +                ASSERT(test_bit(vector, desc->arch.used_vectors));
>                  clear_bit(vector, desc->arch.used_vectors);
>              }
>          }
>
>
>