All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: "Keir (Xen.org)" <keir@xen.org>, Jacob Shin <jacob.shin@amd.com>,
	SuraveeSuthikulpanit <suravee.suthikulpanit@amd.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH v2] AMD/IO-APIC: Use old IO-APIC ack method if AMD 813{1, 2} PCI-X tunnel is present
Date: Wed, 5 Jun 2013 10:43:03 +0100	[thread overview]
Message-ID: <51AF0827.7060507@citrix.com> (raw)
In-Reply-To: <51AF110B02000078000DB586@nat28.tlf.novell.com>

On 05/06/13 09:20, Jan Beulich wrote:
>>>> On 04.06.13 at 18:48, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
>> On 04/06/13 17:29, Jan Beulich wrote:
>>>> +                           "Use ioapic_ack_mode=old\n");
>>> "Don't use \"ioapic_ack=new\"\n" would seem better.
>>>
>>> Jan
>> No - this is more informative to someone who doesn't know the Xen
>> command line arguments inside/out.
> At least the spelling of the option needs to be fixed anyway. And
> the reason I prefer the inverted statement is that if this someone
> adds the suggested option to the beginning of the command line,
> but leaves the bad option in somewhere towards the tail, the bad
> behavior (and the message) will still occur.

I completely missed the spelling - that does need fixing.

While I can appreciate your point of view with the statement, it is only
rare cases where someone would set io_apic_mode anyway and when given
instructions to use =new, can purge instances of =old.

>
> But anyway - I continue to be unconvinced that this case can't be
> easily enough dealt with the admin adding "ioapic_ack=old" to the
> command line.
>
> Jan
>

That describes half the errata workarounds we do.  Why does this deserve
different treatment?.

It can certainly can be worked around by using io_apci_ack=old on the
command line, and that is how we verified the 'fix'.  But in the
meantime it took a normally technically-savvy customer 2 months of time
in highest level support (i.e. my colleagues and I) before we got to the
bottom of the issue.

~Andrew

  reply	other threads:[~2013-06-05  9:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-04 10:13 [PATCH v2] AMD/IO-APIC: Use old IO-APIC ack method if AMD 813{1, 2} PCI-X tunnel is present Andrew Cooper
2013-06-04 10:36 ` George Dunlap
2013-06-04 16:29 ` Jan Beulich
2013-06-04 16:48   ` Andrew Cooper
2013-06-05  8:20     ` Jan Beulich
2013-06-05  9:43       ` Andrew Cooper [this message]
2013-06-05  9:54         ` Jan Beulich
2013-06-05 10:39           ` Andrew Cooper
2013-06-05 11:33             ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51AF0827.7060507@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=jacob.shin@amd.com \
    --cc=keir@xen.org \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.