From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51980)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1UkAik-0005N5-JS
	for qemu-devel@nongnu.org; Wed, 05 Jun 2013 06:13:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1UkAif-0002ww-Ra
	for qemu-devel@nongnu.org; Wed, 05 Jun 2013 06:13:34 -0400
Received: from isrv.corpit.ru ([86.62.121.231]:34677)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1UkAif-0002wf-Js
	for qemu-devel@nongnu.org; Wed, 05 Jun 2013 06:13:29 -0400
Message-ID: <51AF0F46.3020002@msgid.tls.msk.ru>
Date: Wed, 05 Jun 2013 14:13:26 +0400
From: Michael Tokarev <mjt@tls.msk.ru>
MIME-Version: 1.0
References: <20130522223817.GB14845@rox.home.comstyle.com>
In-Reply-To: <20130522223817.GB14845@rox.home.comstyle.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Qemu] [PATCH for 1.5] ui/gtk.c: Fix *BSD build of
	Gtk+ UI
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Brad Smith <brad@comstyle.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

23.05.2013 02:38, Brad Smith wrote:
> Fix the build of the Gtk+ UI on *BSD systems.

Can you please describe what exactly was broken on *BSD
systems, -- which file(s) needs this additional
termios.h include?

I want to fix this properly, because now it isn't
"nitpicking", as you say, anymore -- after the
previous pbonzini's changes it does not build
on debian sparc anymore due to some conflicting
includes (which is an unrelated issue, but is
triggered now because every .c file includes
a ton of #defines).

I already asked you the same question on 25.05,
which is about two weeks ago by now, -- did you
had no time to reply so far?

Thanks,

/mjt

> Signed-off-by: Brad Smith <brad@comstyle.com>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> Message-id: 20130521161324.GA29977@rox.home.comstyle.com
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> 
> diff --git a/include/qemu-common.h b/include/qemu-common.h
> index af769f5..c944bb7 100644
> --- a/include/qemu-common.h
> +++ b/include/qemu-common.h
> @@ -45,6 +45,7 @@
>  #if defined(__GLIBC__)
>  # include <pty.h>
>  #elif defined CONFIG_BSD
> +# include <termios.h>
>  # if defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || defined(__DragonFly__)
>  #  include <libutil.h>
>  # else
>