From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: Multiple issues with omapdrm Date: Wed, 5 Jun 2013 13:55:25 +0300 Message-ID: <51AF191D.8090108@ti.com> References: <51AEFDEF.7060602@ti.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0914806980==" Return-path: Received: from devils.ext.ti.com (devils.ext.ti.com [198.47.26.153]) by gabe.freedesktop.org (Postfix) with ESMTP id 0B752E64D5 for ; Wed, 5 Jun 2013 03:55:27 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Rob Clark Cc: dri-devel List-Id: dri-devel@lists.freedesktop.org --===============0914806980== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="----enig2RSHEISVEKODQDVGHISHO" ------enig2RSHEISVEKODQDVGHISHO Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 05/06/13 13:43, Rob Clark wrote: > On Wed, Jun 5, 2013 at 4:59 AM, Tomi Valkeinen = wrote: >> Hi, >> >> I did some testing with omapdrm on v3.10-rc1. Here are some issues I e= ncountered. >> For most of them I don't have any idea where to even start looking for= a problem, >> so I hope that you may have some ideas. >> >> >> dispc_runtime_get/put used in irq context >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> >> dispc_runtime_get/put are used in irq context in omap_irq.c. I can hac= k >> around that with if (!in_atomic()), but I have no idea yet how to fix >> it properly. >=20 > Probably should have a flag/refcnt that is set when in the irq hander, > since we know that things are on in irq. Maybe. However, I'd like more an approach where the dispc registers are only programmed when a display is enabled. If the display in question is disabled, no registers would be written. I think that would also support losing DISPC register context. The DISPC driver currently stores all its registers when the pm_runtime refcount goes to 0, and restores them on pm_runtime_get. That's a bit heavy, and uses the OMAP specific ctx-loss-count support, which should be removed (and if that's removed, the register save/restore becomes even heavier). Things would be simpler if omapdrm (and omapfb) knows how to program all the relevant registers when a display is enabled, and keeps the necessary state stored in memory (including irq settings). > somewhere in the cleanup it should do a put_paddr(). Otoh, I have > some skepticism about whether module unloading is really going to be > that reliable in practice, so meh.. Why is that? Tomi ------enig2RSHEISVEKODQDVGHISHO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRrxkdAAoJEPo9qoy8lh71oiQP/2+fj2GOaUA0gt3QYYM9SdgM O/tvw2da3TqKjsTLiI38HjBxNCf5sx2GmaDnL+wwFYnXJOEuETpb6j6gDK9l1iJq TSsqA9F+b4MvYayF8fKVRpgPXSLAXkQTkOH9nKp8J20EuMOJL/BS9MC1pfifV6FY gRhSPzgRrPXavFcn1IdhY2wxevDxqdJSYuBECawKzpJhdPmyuctB7NL67jQXWPdS ElKloIDzfl16OHCCgVQMyf7hGKd/EeXbtPJAn+ri0IJ/CeVJntJhSWIJsIJyGSVM 4AwYbpSZD1o6w9AGAqVvOYRitxSwH+/FJC9pBSid2aTz2G6sUMWUHdnxzL5bpMwv s/4QszR5XHmYTFHsreed774Axn/nUmEsWt3hAKQN2CGYQpvgblIMojl2SXpAauTz d1aP5yovMa6T8tbdtZtstD4MPvdjIseLlH1joW3oRzjLnRihoG3j5Zaf2jVdUXlr i9s1945kPNfq4wZkQTP2nwkuKy25EYXk7ESKI33r1qOkyEoQSuCDDY8F4pZV+Tex SpbPe/jfhh8vskfKNVBuvlRBNtgKPo+sk/TrUC8EPG+jL+hwkht2sAEVU9/TbP83 VW1C2nC172LcJBWiYET2BWsfUPqySwm9iDT89srVae2c0oYg2pyFTE24MHAsfqo7 UzCOAVbjQCOu3wCLmsOW =Kdbq -----END PGP SIGNATURE----- ------enig2RSHEISVEKODQDVGHISHO-- --===============0914806980== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0914806980==--