From: Andrew Cooper <andrew.cooper3@citrix.com>
To: George Dunlap <George.Dunlap@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
"mattjd@gmail.com" <mattjd@gmail.com>,
"security@xen.org" <security@xen.org>
Subject: Re: [PATCH 03/16] libelf: add `struct elf_binary*' parameter to elf_load_image
Date: Wed, 5 Jun 2013 12:01:04 +0100 [thread overview]
Message-ID: <51AF1A70.2060605@citrix.com> (raw)
In-Reply-To: <CAFLBxZZwKp1HZD2XDZ9vJhRwiHuvWXSXhM_vMt6GBWBhDNEfZw@mail.gmail.com>
On 05/06/13 11:32, George Dunlap wrote:
> On Tue, Jun 4, 2013 at 6:59 PM, Ian Jackson <ian.jackson@eu.citrix.com> wrote:
>> The meat of this function is going to need a copy of the elf pointer,
>> in forthcoming patches.
>>
>> No functional change in this patch.
>>
>> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
>> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Is there any reason not to commit the patches that have been acked and
> reviewed, so we can start getting stuff tested sooner (and reduce the
> cognitive load on you of having to deal with 16 patches)?
>
> -George
I would certainly appreciate a reduction of cognative load.
>From the series, I believe that patches 1-6 are sufficiently simple and
obviously correct.
~Andrew
next prev parent reply other threads:[~2013-06-05 11:01 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-04 17:59 [PATCH 4 00/16] XSA55 libelf fixes for unstable Ian Jackson
2013-06-04 17:59 ` [PATCH 01/16] libelf: abolish libelf-relocate.c Ian Jackson
2013-06-04 17:59 ` [PATCH 02/16] libxc: introduce xc_dom_seg_to_ptr_pages Ian Jackson
2013-06-04 17:59 ` [PATCH 03/16] libelf: add `struct elf_binary*' parameter to elf_load_image Ian Jackson
2013-06-05 10:32 ` George Dunlap
2013-06-05 11:01 ` Andrew Cooper [this message]
2013-06-05 11:54 ` Ian Jackson
2013-06-04 17:59 ` [PATCH 04/16] libelf: abolish elf_sval and elf_access_signed Ian Jackson
2013-06-04 17:59 ` [PATCH 05/16] libelf: move include of <asm/guest_access.h> to top of file Ian Jackson
2013-06-04 17:59 ` [PATCH 06/16] libelf/xc_dom_load_elf_symtab: Do not use "syms" uninitialised Ian Jackson
2013-06-04 17:59 ` [PATCH 07/16] libelf: introduce macros for memory access and pointer handling Ian Jackson
2013-06-04 17:59 ` [PATCH 08/16] tools/xcutils/readnotes: adjust print_l1_mfn_valid_note Ian Jackson
2013-06-04 17:59 ` [PATCH 09/16] libelf: check nul-terminated strings properly Ian Jackson
2013-06-04 17:59 ` [PATCH 10/16] libelf: check all pointer accesses Ian Jackson
2013-06-06 11:19 ` George Dunlap
2013-06-06 14:51 ` Ian Jackson
2013-06-06 16:20 ` George Dunlap
2013-06-06 18:11 ` Ian Jackson
2013-06-06 12:25 ` Matthew Daley
2013-06-06 14:59 ` Ian Jackson
2013-06-07 3:44 ` Matthew Daley
2013-06-06 15:30 ` Ian Campbell
2013-06-07 4:03 ` Matthew Daley
2013-06-04 17:59 ` [PATCH 11/16] libelf: Check pointer references in elf_is_elfbinary Ian Jackson
2013-06-04 17:59 ` [PATCH 12/16] libelf: Make all callers call elf_check_broken Ian Jackson
2013-06-05 14:51 ` Andrew Cooper
2013-06-05 15:31 ` Andrew Cooper
2013-06-06 14:08 ` George Dunlap
2013-06-06 18:41 ` Ian Jackson
2013-06-04 18:00 ` [PATCH 13/16] libelf: use C99 bool for booleans Ian Jackson
2013-06-06 14:28 ` George Dunlap
2013-06-06 14:46 ` Ian Jackson
2013-06-04 18:00 ` [PATCH 14/16] libelf: use only unsigned integers Ian Jackson
2013-06-06 16:07 ` George Dunlap
2013-06-06 18:14 ` Ian Jackson
2013-06-07 7:14 ` Jan Beulich
2013-06-07 14:35 ` Ian Jackson
2013-06-07 15:50 ` Jan Beulich
2013-06-04 18:00 ` [PATCH 15/16] libelf: check loops for running away Ian Jackson
2013-06-04 18:00 ` [PATCH 16/16] libelf: abolish obsolete macros Ian Jackson
2013-06-04 18:08 ` [PATCH 4 00/16] XSA55 libelf fixes for unstable Ian Jackson
2013-06-04 21:39 ` Andrew Cooper
2013-06-05 11:53 ` Ian Jackson
2013-06-06 14:04 ` Matthew Daley
2013-06-06 18:39 ` Ian Jackson
2013-06-07 3:35 ` Matthew Daley
-- strict thread matches above, loose matches on Subject: below --
2013-06-03 15:41 [PATCH v3.1 " Ian Jackson
2013-06-03 15:41 ` [PATCH 03/16] libelf: add `struct elf_binary*' parameter to elf_load_image Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AF1A70.2060605@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=mattjd@gmail.com \
--cc=security@xen.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.