Re: [Qemu-devel] [PATCH 04/13] pseries: savevm support for XICS interrupt controller

[Alexey Kardashevskiy <aik@ozlabs.ru>]

On 05.06.2013 19:55, David Gibson wrote:
> On Wed, Jun 05, 2013 at 01:22:02PM +1000, Alexey Kardashevskiy wrote:
>> On 06/04/2013 10:20 PM, Alexey Kardashevskiy wrote:
> [snip]
>>> +static int ics_post_load(void *opaque, int version_id)
>>> +{
>>> +    int i;
>>> +    struct ics_state *ics = opaque;
>>> +
>>> +    for (i = 0; i < ics->nr_irqs; i++) {
>>
>> Obviously here is a bug...
>>
>> -    for (i = 0; i < ics->nr_irqs; i++) {
>> +    for (i = 0; i < ics->icp->nr_servers; i++) {
> 
> Ah.. yes.  Although it would be a little nicer to avoid the duplicate
> calls to ics_resend() that will cause.  Still the simple version
> should be correct for now.  Please resend with this fixed.

I'll wait till Friday (do we expect anyone to comment, besides you?) and
repost the whole series with fixed "from" :)


-- 
With best regards

Alexey Kardashevskiy -- icq: 52150396