From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Henningsson Subject: Re: CONFIG_SND_DEBUG Date: Wed, 05 Jun 2013 13:38:55 +0200 Message-ID: <51AF234F.6080802@canonical.com> References: <1370412921.2385.111.camel@joe-AO722> <1370415121.2385.124.camel@joe-AO722> <1370416077.2385.137.camel@joe-AO722> <1370417670.2385.148.camel@joe-AO722> <51AEED12.20502@canonical.com> <20130605105345.GG3073@dm> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130605105345.GG3073@dm> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: kernel-team-bounces@lists.ubuntu.com To: Andy Whitcroft Cc: alsa-devel@alsa-project.org, Takashi Iwai , Kernel team list , Alan Stern , Joe Perches List-Id: alsa-devel@alsa-project.org On 06/05/2013 12:53 PM, Andy Whitcroft wrote: > On Wed, Jun 05, 2013 at 09:47:30AM +0200, David Henningsson wrote: >>>>> On Wed, 2013-06-05 at 08:54 +0200, Takashi Iwai wrote: >>>>>> At Tue, 04 Jun 2013 23:52:01 -0700, Joe Perches wrote: >>>>>>> On Wed, 2013-06-05 at 08:32 +0200, Takashi Iwai wrote: >>>>>>>> Yes. These are snd_printd() just to be conditionally built in. >>>>>>>> But in most cases it's rather useful to print them (as most distros >>>>>>>> set CONFIG_SND_DEBUG=y). >>>>>>> Ubuntu doesn't, I believe Fedora doesn't. >>>>>> Then they should have done so :) >>>>> But they don't, so what distros do? >>>> >>>> RedHat (including Fedora) and SUSE do at least. >>> >>> Mandriva does too. (still looking around for others) >>> >>> We can ask Ubuntu to enable CONFIG_SND_DEBUG. >>> (cc'd Andy Whitcroft, Leann Ogasawara and David Henningsson) >>> >>> Maybe there are others Canonical folk that >>> should be cc'd? >> >> Adding kernel team mailing list to CC. >> >> Andy/Leann - apparently CONFIG_SND_DEBUG is on by default from >> upstream, and we explicitly disable it. Is there any reason why we >> do that? > > config SND_DEBUG > bool "Debug" > help > Say Y here to enable ALSA debug code. > > It is off by default in upstream, and the really helpful description > would cirtainly tend to lead to it being disabled. But if it is helpful > to your debugging efforts David then I suspect we can enable it in Saucy > and see what happens. Okay, so then the ball is back in Takashi's area - if we're recommended to turn CONFIG_SND_DEBUG on, why is it off by default in the upstream Linux kernel? -- David Henningsson, Canonical Ltd. https://launchpad.net/~diwic