From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] arm, arm335x: add watchdog support
Date: Wed, 05 Jun 2013 16:17:41 +0200 [thread overview]
Message-ID: <51AF4885.4090403@denx.de> (raw)
In-Reply-To: <CAOf5uwm6DLoinL9dmwgBG-XH3eRjrEyeQfuMgN=hZeFpzvsGPA@mail.gmail.com>
Hello Michael,
Am 05.06.2013 15:31, schrieb Michael Trimarchi:
> Hi
>
> On Jun 4, 2013 10:55 AM, "Heiko Schocher" <hs at denx.de <mailto:hs@denx.de>> wrote:
>>
>> Add TI OMAP 16xx & 24xx/34xx 32KHz (non-secure) watchdog support.
>>
>> Signed-off-by: Heiko Schocher <hs at denx.de <mailto:hs@denx.de>>
>> Cc: Albert Aribaud <albert.u.boot at aribaud.net <mailto:albert.u.boot@aribaud.net>>
>> Cc: Tom Rini <trini at ti.com <mailto:trini@ti.com>>
>> ---
>> arch/arm/include/asm/arch-am33xx/cpu.h | 20 ++++++
>> drivers/watchdog/Makefile | 1 +
>> drivers/watchdog/omap_wdt.c | 115 +++++++++++++++++++++++++++++++++
>> 3 Dateien ge?ndert, 136 Zeilen hinzugef?gt(+)
>> create mode 100644 drivers/watchdog/omap_wdt.c
[...]
>> diff --git a/drivers/watchdog/omap_wdt.c b/drivers/watchdog/omap_wdt.c
>> new file mode 100644
>> index 0000000..dc4df98
>> --- /dev/null
>> +++ b/drivers/watchdog/omap_wdt.c
>> @@ -0,0 +1,115 @@
[...]
>> + /* wait for posted write to complete */
>> + while ((readl(&wdt->wdtwwps) & WDT_WWPS_PEND_WTGR))
>> + ;
>> +}
>> +
>
> I think that this patch has some problem because watchdog reset is in getc code. Did you try to paste very long string when it is enabled? You need to
> avoid reset when it is not needed
I think, I do not understand you ... this is for all watchdogs
the case ...
I currently pasted a 500 bytes long string, seeing no problems
with the watchdog...
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2013-06-05 14:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-04 8:55 [U-Boot] arm, arm335x: add watchdog support Heiko Schocher
2013-06-04 21:24 ` Tom Rini
2013-06-05 5:22 ` Heiko Schocher
2013-06-05 12:19 ` Tom Rini
2013-06-05 13:31 ` Michael Trimarchi
2013-06-05 14:17 ` Heiko Schocher [this message]
2013-06-05 14:21 ` Michael Trimarchi
2013-06-05 14:26 ` Heiko Schocher
2013-06-05 20:58 ` Michael Trimarchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AF4885.4090403@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.