From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1UkJvw-0003Kk-1v for mharc-qemu-trivial@gnu.org; Wed, 05 Jun 2013 16:03:48 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34401) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkJvp-0003E3-Ue for qemu-trivial@nongnu.org; Wed, 05 Jun 2013 16:03:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UkJvl-0007Jf-Dc for qemu-trivial@nongnu.org; Wed, 05 Jun 2013 16:03:41 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:42124) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkJvV-0007E7-06; Wed, 05 Jun 2013 16:03:21 -0400 Received: from [192.168.88.2] (mjt.vpn.tls.msk.ru [192.168.177.99]) by isrv.corpit.ru (Postfix) with ESMTP id 72A2840AD7; Thu, 6 Jun 2013 00:03:18 +0400 (MSK) Message-ID: <51AF9984.8030103@msgid.tls.msk.ru> Date: Thu, 06 Jun 2013 00:03:16 +0400 From: Michael Tokarev Organization: Telecom Service, JSC User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:17.0) Gecko/17.0 Icedove/17.0 MIME-Version: 1.0 To: Ed Maste References: <1370444532-68682-1-git-send-email-emaste@freebsd.org> In-Reply-To: <1370444532-68682-1-git-send-email-emaste@freebsd.org> X-Enigmail-Version: 1.5.1 OpenPGP: id=804465C5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 86.62.121.231 Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org Subject: Re: [Qemu-trivial] [PATCH] configure: Use ${config_host_ld} variable X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Jun 2013 20:03:47 -0000 05.06.2013 19:02, Ed Maste wrote: > - linker_script="-Wl,-T../config-host.ld -Wl,-T,\$(SRC_PATH)/ldscripts/\$(ARCH).ld" > + linker_script="-Wl,-T../${config_host_ld} -Wl,-T,\$(SRC_PATH)/ldscripts/\$(ARCH).ld" Do we really care? To me it looks like it is better to just remove the variable (which is nothing but just an extra indirection) and be done with it. The variable has been introduced by this commit: commit 4bf6b55b346d33ff16dd25f75bbea8e21f95dfa6 Author: Juan Quintela Date: Wed Jul 22 22:37:40 2009 +0200 set SEARCH_PATH for the linker script from output of ld --verbose -v Signed-off-by: Juan Quintela Signed-off-by: Anthony Liguori which description does not cover introduction of this variable, and apparently it meant to be something different really. The thing is: that commit introduced that envvar, but at the same time, added several references to open-coded name (config-host.ld) into several places (including the one which is being patched now). I really don't see a point to have it in a variable at all. Ditto for $config_host_mak for that matter. Both are used in makefiles as well, and used there directly. Maybe just get rid of that cruft? If there will be a need for actual variable, it will be trivial to introduce it and patch in this single place where it is referenced... :) Thanks, /mjt From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34343) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkJvf-0003AI-Me for qemu-devel@nongnu.org; Wed, 05 Jun 2013 16:03:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UkJvV-0007GK-7k for qemu-devel@nongnu.org; Wed, 05 Jun 2013 16:03:31 -0400 Message-ID: <51AF9984.8030103@msgid.tls.msk.ru> Date: Thu, 06 Jun 2013 00:03:16 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <1370444532-68682-1-git-send-email-emaste@freebsd.org> In-Reply-To: <1370444532-68682-1-git-send-email-emaste@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Use ${config_host_ld} variable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ed Maste Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org 05.06.2013 19:02, Ed Maste wrote: > - linker_script="-Wl,-T../config-host.ld -Wl,-T,\$(SRC_PATH)/ldscripts/\$(ARCH).ld" > + linker_script="-Wl,-T../${config_host_ld} -Wl,-T,\$(SRC_PATH)/ldscripts/\$(ARCH).ld" Do we really care? To me it looks like it is better to just remove the variable (which is nothing but just an extra indirection) and be done with it. The variable has been introduced by this commit: commit 4bf6b55b346d33ff16dd25f75bbea8e21f95dfa6 Author: Juan Quintela Date: Wed Jul 22 22:37:40 2009 +0200 set SEARCH_PATH for the linker script from output of ld --verbose -v Signed-off-by: Juan Quintela Signed-off-by: Anthony Liguori which description does not cover introduction of this variable, and apparently it meant to be something different really. The thing is: that commit introduced that envvar, but at the same time, added several references to open-coded name (config-host.ld) into several places (including the one which is being patched now). I really don't see a point to have it in a variable at all. Ditto for $config_host_mak for that matter. Both are used in makefiles as well, and used there directly. Maybe just get rid of that cruft? If there will be a need for actual variable, it will be trivial to introduce it and patch in this single place where it is referenced... :) Thanks, /mjt