From: Wolfgang Grandegger <wg@grandegger.com>
To: Henri Roosen <henriroosen@gmail.com>
Cc: Thierry Bultel <thierry.bultel@wanadoo.fr>, xenomai@xenomai.org
Subject: Re: [Xenomai] Init issue with rtcan_flexcan
Date: Thu, 06 Jun 2013 09:07:39 +0200 [thread overview]
Message-ID: <51B0353B.7060206@grandegger.com> (raw)
In-Reply-To: <CANKLDmugXc4M08TYJaq0ON-Ls04=xk=6oh3dR0gLD0CPBxZjxg@mail.gmail.com>
Hi Henri,
On 06/05/2013 09:15 AM, Henri Roosen wrote:
> On Fri, Dec 14, 2012 at 5:38 PM, Wolfgang Grandegger <wg@grandegger.com>wrote:
>
>> On 12/14/2012 03:23 PM, Thierry Bultel wrote:
>>> Hi,
>>> some days ago I have posted a patch for the rtcan_flexcan to be
>>> correctly probed on the iMX6q
>>>
>>> It is functional, but I have not tested it enough, I am sorry about that.
>>> It only works if the linux flexcan driver module has been used once
>> before.
>>>
>>> Else I have got IRQs but no packet go to the upper layer, I think it is
>>> stuck in passive state, I am investigating on it.
>>
>> It would be nice if you could port the missing patches from the mainline
>> Linux kernel to rtcan_flexcan.
>>
>
> I have ported code from the mainline linux flexcan driver that fixes the
> behavior described by Thierry. Please find attached:
> 0001-make-rtcan_flexcan-driver-compatible-with-non-OpenFi.patch
> 0002-Fix-rtcan_flexcan-for-mx6-for-OpenFirmware-platforms.patch
>
> The attached patches can be applied to the current mainline xenomai git
> (anywhere after commit-3ddc61cda095a9ae51277608d7fd4e9c2c481625). They make
> Thierry's patch obsolete.
>
> I have tested the rtcan_flexcan driver in the non-CONFIG_OF configuration
> only. On a wandboard with iMX6Solo using the freescale 3.0 kernel. I only
> compile tested the CONFIG_OF configuration for the current ipipe master
> (3.8) because wandboard solo is not yet supported by OpenFirmware. It would
> be great if someone could test the OF version.
Thanks for your contribution. Looks good at a first glance. Just need to
check back- (and forward-) compatibility. I will also try to get access
to boards using Flexcan. Hope to find some time over the WE.
Wolfgang.
next prev parent reply other threads:[~2013-06-06 7:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-14 14:23 [Xenomai] Init issue with rtcan_flexcan Thierry Bultel
2012-12-14 16:38 ` Wolfgang Grandegger
2013-06-05 7:15 ` Henri Roosen
2013-06-06 7:07 ` Wolfgang Grandegger [this message]
2013-06-19 20:26 ` Wolfgang Grandegger
2013-07-13 14:51 ` Gilles Chanteperdrix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B0353B.7060206@grandegger.com \
--to=wg@grandegger.com \
--cc=henriroosen@gmail.com \
--cc=thierry.bultel@wanadoo.fr \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.