On 05.06.2013 20:14, Paul Eggleton wrote:

Hi Calin,

Hi Paul,


On Wednesday 05 June 2013 11:23:57 Dragomir, CalinX L wrote:

I've updated the Django models information based on this.
The outcome is now  limited only to these five options discussed.
Please find my changes here:
https://wiki.yoctoproject.org/wiki/Django_models

Some feedback on the models:

* I understand task_history is meant to capture where BitBake could have 
accelerated the task using sstate but was unable to for some reason. Can we 
have a choice field which indicates this directly (e.g. sstate_result - not 
applicable, unavailable, failed, restored)?

I will change this task_history field into a CharField with only those 4 possible choices and will name it sstate_result.
Belen, are you ok with this? Can you please update the info in the task table based on this?


* I agree we want to have a sequence number to allow us to easily show the 
order tasks ran in within the UI where needed (is that task_number in the 
current model? If so do we need the order field which is also listed?)

This is actually a question I had earlier. Task_number isn't listed in the table from bug #4275. We should drop on one of the task_number and order fields.
I think order should be renamed as task_number in the table, and I will drop order in the Django model.
Belen, do you agree ?


* I wonder if task_type should instead be an boolean value indicating if the 
task executed or not; I can't think of any other value we'd want here that 
isn't already covered by task_outcome.

Since this has only two options it acts like a boolean.
I think we can make it a BooleanField. Where True means Executed, and False means Prebuilt.


* What is the "code" field?

On the agency page here ( http://www.yoctoproject.org/webhob/phase3_final_web_prototype/project-build-tasks-task.html) under the Code section I see a block of code, and
this is why I have put a TextField there.

On the other hand, going through the tasks tabel v4 , I see that depending on the script type, we have a path for shell and a path , function and line number for python code.
Belen, what is desired here exactly?


* "py_sh" should probably be named "script_type" or similar

Yes, I agree, I'll change this accordingly.


Cheers,
Paul

Thank you for the feedback Paul, I will update the info on the wiki shortly if you don't have other comments on these.

Thanks,
Calin