From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 33FDEE01567 for ; Thu, 6 Jun 2013 02:25:27 -0700 (PDT) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 06 Jun 2013 02:25:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,814,1363158000"; d="scan'208,217";a="349112218" Received: from calin-desktop.rb.intel.com (HELO [10.237.105.64]) ([10.237.105.64]) by orsmga002.jf.intel.com with ESMTP; 06 Jun 2013 02:25:24 -0700 Message-ID: <51B055ED.5010000@linux.intel.com> Date: Thu, 06 Jun 2013 12:27:09 +0300 From: Calin Dragomir User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Paul Eggleton , webhob@yoctoproject.org, "Barros Pena, Belen" , "Damian, Alexandru" References: <27CEE5FF4D395E43B04459808802ADB7013EFFE0@IRSMSX106.ger.corp.intel.com> <5116417.al1Mo7JSpa@helios> In-Reply-To: <5116417.al1Mo7JSpa@helios> Subject: Re: [Webhob] Django models X-BeenThere: webhob@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Jun 2013 09:25:27 -0000 Content-Type: multipart/alternative; boundary="------------040404050407020109060208" --------------040404050407020109060208 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 05.06.2013 20:14, Paul Eggleton wrote: > Hi Calin, Hi Paul, > > On Wednesday 05 June 2013 11:23:57 Dragomir, CalinX L wrote: >> I've updated the Django models information based on this. >> The outcome is now limited only to these five options discussed. >> Please find my changes here: >> https://wiki.yoctoproject.org/wiki/Django_models > Some feedback on the models: > > * I understand task_history is meant to capture where BitBake could have > accelerated the task using sstate but was unable to for some reason. Can we > have a choice field which indicates this directly (e.g. sstate_result - not > applicable, unavailable, failed, restored)? I will change this task_history field into a CharField with only those 4 possible choices and will name it sstate_result. Belen, are you ok with this? Can you please update the info in the task table based on this? > > * I agree we want to have a sequence number to allow us to easily show the > order tasks ran in within the UI where needed (is that task_number in the > current model? If so do we need the order field which is also listed?) This is actually a question I had earlier. Task_number isn't listed in the table from bug #4275. We should drop on one of the task_number and order fields. I think order should be renamed as task_number in the table, and I will drop order in the Django model. Belen, do you agree ? > > * I wonder if task_type should instead be an boolean value indicating if the > task executed or not; I can't think of any other value we'd want here that > isn't already covered by task_outcome. Since this has only two options it acts like a boolean. I think we can make it a BooleanField. Where True means Executed, and False means Prebuilt. > > * What is the "code" field? On the agency page here ( http://www.yoctoproject.org/webhob/phase3_final_web_prototype/project-build-tasks-task.html) under the Code section I see a block of code, and this is why I have put a TextField there. On the other hand, going through the tasks tabel v4 , I see that depending on the script type, we have a path for shell and a path , function and line number for python code. Belen, what is desired here exactly? > > * "py_sh" should probably be named "script_type" or similar Yes, I agree, I'll change this accordingly. > > Cheers, > Paul > Thank you for the feedback Paul, I will update the info on the wiki shortly if you don't have other comments on these. Thanks, Calin --------------040404050407020109060208 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit
On 05.06.2013 20:14, Paul Eggleton wrote:
Hi Calin,
Hi Paul,

On Wednesday 05 June 2013 11:23:57 Dragomir, CalinX L wrote:

I've updated the Django models information based on this.
The outcome is now  limited only to these five options discussed.
Please find my changes here:
https://wiki.yoctoproject.org/wiki/Django_models

Some feedback on the models:

* I understand task_history is meant to capture where BitBake could have 
accelerated the task using sstate but was unable to for some reason. Can we 
have a choice field which indicates this directly (e.g. sstate_result - not 
applicable, unavailable, failed, restored)?

I will change this task_history field into a CharField with only those 4 possible choices and will name it sstate_result.
Belen, are you ok with this? Can you please update the info in the task table based on this?


* I agree we want to have a sequence number to allow us to easily show the 
order tasks ran in within the UI where needed (is that task_number in the 
current model? If so do we need the order field which is also listed?)

This is actually a question I had earlier. Task_number isn't listed in the table from bug #4275. We should drop on one of the task_number and order fields.
I think order should be renamed as task_number in the table, and I will drop order in the Django model.
Belen, do you agree ?


* I wonder if task_type should instead be an boolean value indicating if the 
task executed or not; I can't think of any other value we'd want here that 
isn't already covered by task_outcome.

Since this has only two options it acts like a boolean.
I think we can make it a BooleanField. Where True means Executed, and False means Prebuilt.


* What is the "code" field?

On the agency page here ( http://www.yoctoproject.org/webhob/phase3_final_web_prototype/project-build-tasks-task.html) under the Code section I see a block of code, and
this is why I have put a TextField there.

On the other hand, going through the tasks tabel v4 , I see that depending on the script type, we have a path for shell and a path , function and line number for python code.
Belen, what is desired here exactly?


* "py_sh" should probably be named "script_type" or similar

Yes, I agree, I'll change this accordingly.

Cheers,
Paul

Thank you for the feedback Paul, I will update the info on the wiki shortly if you don't have other comments on these.

Thanks,
Calin

--------------040404050407020109060208--