From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36960) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkYfO-0006sM-5M for qemu-devel@nongnu.org; Thu, 06 Jun 2013 07:47:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UkYfI-0004a6-Dt for qemu-devel@nongnu.org; Thu, 06 Jun 2013 07:47:42 -0400 Received: from cantor2.suse.de ([195.135.220.15]:57296 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkYfI-0004Zj-2s for qemu-devel@nongnu.org; Thu, 06 Jun 2013 07:47:36 -0400 Message-ID: <51B076D4.9080101@suse.de> Date: Thu, 06 Jun 2013 13:47:32 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <54453b6aa8afa1a76b2ec1932f1d7fd25205d0bc.1370496582.git.peter.crosthwaite@xilinx.com> In-Reply-To: <54453b6aa8afa1a76b2ec1932f1d7fd25205d0bc.1370496582.git.peter.crosthwaite@xilinx.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 1/2] audio/intel-hda: Fix Inheritance hierachy List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: peter.crosthwaite@xilinx.com Cc: edgar.iglesias@gmail.com, qemu-devel@nongnu.org, kraxel@redhat.com Am 06.06.2013 07:34, schrieb peter.crosthwaite@xilinx.com: > From: Peter Crosthwaite >=20 > The ich6 and ich9 variants either need to inherit one from the other, > or both from a common base class, otherwise its not possible to create > a QOM cast macro for use by the shared implementation functions. > Went for option B, with a common base class. >=20 > Signed-off-by: Peter Crosthwaite Looks fine, Reviewed-by: Andreas F=E4rber Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg