From: "Arend van Spriel" <arend@broadcom.com>
To: "Hauke Mehrtens" <hauke@hauke-m.de>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
brcm80211-dev-list@broadcom.com
Subject: Re: [PATCH 03/15] brcmsmac: remove brcms_bss_cfg->BSS
Date: Thu, 6 Jun 2013 14:05:55 +0200 [thread overview]
Message-ID: <51B07B23.1090205@broadcom.com> (raw)
In-Reply-To: <1364085963-25940-4-git-send-email-hauke@hauke-m.de>
On 03/24/2013 01:45 AM, Hauke Mehrtens wrote:
> This was a read only member. The checks using BSS are replaced by
> better fitting checks of the new type member.
>
> The change in brcms_c_tbtt() was based on code from b43, in
> brcms_c_ps_allowed() the same happens with BSS being true or false,
> beaconing and probe responses are just needed in ap mode.
>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
> drivers/net/wireless/brcm80211/brcmsmac/main.c | 23 +++++++++--------------
> drivers/net/wireless/brcm80211/brcmsmac/main.h | 2 --
> 2 files changed, 9 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/main.c b/drivers/net/wireless/brcm80211/brcmsmac/main.c
> index 4e420ea..90e6c0d 100644
> --- a/drivers/net/wireless/brcm80211/brcmsmac/main.c
> +++ b/drivers/net/wireless/brcm80211/brcmsmac/main.c
> @@ -1069,7 +1069,7 @@ brcms_b_txstatus(struct brcms_hardware *wlc_hw, bool bound, bool *fatal)
>
> static void brcms_c_tbtt(struct brcms_c_info *wlc)
> {
> - if (!wlc->bsscfg->BSS)
> + if (wlc->bsscfg->type == BRCMS_TYPE_ADHOC)
> /*
> * DirFrmQ is now valid...defer setting until end
> * of ATIM window
Hi Hauke,
Sorry for such a late comment. It seem that the above change is
incosistent with the changes below. You probably need to change it.
Gr. AvS
> @@ -7386,7 +7379,8 @@ void brcms_c_update_beacon(struct brcms_c_info *wlc)
> {
> struct brcms_bss_cfg *bsscfg = wlc->bsscfg;
>
> - if (bsscfg->up && !bsscfg->BSS)
> + if (bsscfg->up && (bsscfg->type == BRCMS_TYPE_AP ||
> + bsscfg->type == BRCMS_TYPE_ADHOC))
> /* Clear the soft intmask */
> wlc->defmacintmask &= ~MI_BCNTPL;
> }
> @@ -7461,7 +7455,8 @@ void brcms_c_update_probe_resp(struct brcms_c_info *wlc, bool suspend)
> struct brcms_bss_cfg *bsscfg = wlc->bsscfg;
>
> /* update AP or IBSS probe responses */
> - if (bsscfg->up && !bsscfg->BSS)
> + if (bsscfg->up && (bsscfg->type == BRCMS_TYPE_AP ||
> + bsscfg->type == BRCMS_TYPE_ADHOC))
> brcms_c_bss_update_probe_resp(wlc, bsscfg, suspend);
> }
>
next prev parent reply other threads:[~2013-06-06 12:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-24 0:45 [PATCH 00/15] brcmsmac: add AP mode Hauke Mehrtens
2013-03-24 0:45 ` [PATCH 01/15] brcmsmac: implement ieee80211_ops get_tsf and set_tsf Hauke Mehrtens
2013-03-24 0:45 ` [PATCH 02/15] brcmsmac: add interface type to brcms_bss_cfg Hauke Mehrtens
2013-03-24 0:45 ` [PATCH 03/15] brcmsmac: remove brcms_bss_cfg->BSS Hauke Mehrtens
2013-06-06 12:05 ` Arend van Spriel [this message]
2013-06-12 13:46 ` Hauke Mehrtens
2013-03-24 0:45 ` [PATCH 04/15] brcmsmac: remove brcms_bss_cfg->associated Hauke Mehrtens
2013-05-18 19:53 ` REGRESSION: v3.10-rc1: " Arend van Spriel
2013-05-18 23:34 ` Jonas Gorski
2013-05-19 8:31 ` Arend van Spriel
2013-05-19 8:21 ` Arend van Spriel
2013-05-19 10:24 ` Hauke Mehrtens
2013-05-28 20:05 ` Hauke Mehrtens
2013-03-24 0:45 ` [PATCH 05/15] brcmsmac: remove brcms_bss_cfg->enable Hauke Mehrtens
2013-03-24 0:45 ` [PATCH 06/15] brcmsmac: remove brcms_bss_cfg->up Hauke Mehrtens
2013-03-24 0:45 ` [PATCH 07/15] brcmsmac: remove brcms_bss_cfg->cur_etheraddr Hauke Mehrtens
2013-03-24 0:45 ` [PATCH 08/15] brcmsmac: remove brcms_pub->bcmerr Hauke Mehrtens
2013-03-24 0:45 ` [PATCH 09/15] brcmsmac: write beacon period to hardware Hauke Mehrtens
2013-03-24 0:45 ` [PATCH 10/15] brcmsmac: add beacon template support Hauke Mehrtens
2013-03-24 0:45 ` [PATCH 11/15] brcmsmac: react on changing SSID Hauke Mehrtens
2013-03-24 0:46 ` [PATCH 12/15] brcmsmac: add support for probe response template Hauke Mehrtens
2013-03-24 0:46 ` [PATCH 13/15] brcmsmac: deactivate ucode sending probe responses Hauke Mehrtens
2013-03-24 0:46 ` [PATCH 14/15] brcmsmac: activate AP support Hauke Mehrtens
2013-03-24 0:46 ` [PATCH 15/15] brcmsmac: add support for adhoc mode Hauke Mehrtens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B07B23.1090205@broadcom.com \
--to=arend@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=hauke@hauke-m.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.