From: Daniel Mack <zonque@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: ALSA development <alsa-devel@alsa-project.org>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: Generic clock divider indices
Date: Thu, 06 Jun 2013 16:09:52 +0200 [thread overview]
Message-ID: <51B09830.7020208@gmail.com> (raw)
In-Reply-To: <20130606135605.GB9980@sirena.org.uk>
On 06.06.2013 15:56, Mark Brown wrote:
> On Thu, Jun 06, 2013 at 03:44:04PM +0200, Daniel Mack wrote:
>
>> Would it be an idea to define some commonly used dividers in the core?
>> If they start at 0x80000000, they won't collide with existing ones, and
>> we could simply add them as alternative case statements to existing drivers.
>
> I don't think this is a terribly sensible idea; as soon as you start
> relying on these dividers in machine code you're going to run into
> drivers that just don't implement them either due to hardware or due to
> them being able to figure things out by themselves and...
I do see that we have a way to propagate the sysclk, but how would you
determine the bit clock rate from a codec driver?
Also, the same problem with freely definable indices is true for
.set_sysclk() as well. Not all drivers expect the actual MCLK rate here.
Daniel
next prev parent reply other threads:[~2013-06-06 14:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-06 13:44 Generic clock divider indices Daniel Mack
2013-06-06 13:56 ` Mark Brown
2013-06-06 14:09 ` Daniel Mack [this message]
2013-06-06 14:24 ` Mark Brown
2013-06-06 14:31 ` Daniel Mack
2013-06-06 14:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B09830.7020208@gmail.com \
--to=zonque@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.