From: Jonathan Cameron <jic23@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, lars@metafoo.de, kbuild-all@01.org,
Fengguang Wu <fengguang.wu@intel.com>
Subject: Re: [PATCH] iio:trigger:interrupt fix formatting of rsize variable in name
Date: Thu, 06 Jun 2013 19:26:33 +0100 [thread overview]
Message-ID: <51B0D459.1080702@kernel.org> (raw)
In-Reply-To: <1370543094-10248-1-git-send-email-jic23@kernel.org>
On 06/06/2013 07:24 PM, Jonathan Cameron wrote:
> The name includes irq_res->start which of type resource_size_t not integer.
> We could in theory use %pa for this but then it would be in hex and also
> that causes a warning about incorrect types anyway. Hence just
> use the irq local variable we assigned the line above.
>
Sorry, sent the wrong version out due to forgetting to update the commit.
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
> ---
> drivers/iio/trigger/iio-trig-interrupt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/trigger/iio-trig-interrupt.c b/drivers/iio/trigger/iio-trig-interrupt.c
> index 84bf397..0a6756d 100644
> --- a/drivers/iio/trigger/iio-trig-interrupt.c
> +++ b/drivers/iio/trigger/iio-trig-interrupt.c
> @@ -50,7 +50,7 @@ static int iio_interrupt_trigger_probe(struct platform_device *pdev)
>
> irq = irq_res->start;
>
> - trig = iio_trigger_alloc("irqtrig%d", irq_res->start);
> + trig = iio_trigger_alloc("irqtrig%zu", irq_res->start);
> if (!trig) {
> ret = -ENOMEM;
> goto error_ret;
>
prev parent reply other threads:[~2013-06-06 18:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-06 18:24 [PATCH] iio:trigger:interrupt fix formatting of rsize variable in name Jonathan Cameron
2013-06-06 18:26 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B0D459.1080702@kernel.org \
--to=jic23@kernel.org \
--cc=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.