From: Jonathan Cameron <jic23@kernel.org>
To: Roland Stigge <stigge@antcom.de>
Cc: Sachin Kamat <sachin.kamat@linaro.org>,
devel@driverdev.osuosl.org, linux-iio@vger.kernel.org,
gregkh@linuxfoundation.org, jic23@cam.ac.uk
Subject: Re: [PATCH 3/3] staging: iio: lpc32xx_adc: Remove redundant platform_set_drvdata()
Date: Thu, 06 Jun 2013 19:49:20 +0100 [thread overview]
Message-ID: <51B0D9B0.3050306@kernel.org> (raw)
In-Reply-To: <51B0A668.3060905@antcom.de>
On 06/06/2013 04:10 PM, Roland Stigge wrote:
> On 06/06/2013 11:27 AM, Sachin Kamat wrote:
>> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
>> driver is bound) removes the need to set driver data field to
>> NULL.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> Cc: Roland Stigge <stigge@antcom.de>
>
> Tested-by: Roland Stigge <stigge@antcom.de>
> Acked-by: Roland Stigge <stigge@antcom.de>
>
All 3 applied to the togreg branch of iio.git
Thanks
> Thanks!
>
>> ---
>> drivers/staging/iio/adc/lpc32xx_adc.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/staging/iio/adc/lpc32xx_adc.c b/drivers/staging/iio/adc/lpc32xx_adc.c
>> index 2f2f7fd..9a4bb09 100644
>> --- a/drivers/staging/iio/adc/lpc32xx_adc.c
>> +++ b/drivers/staging/iio/adc/lpc32xx_adc.c
>> @@ -215,7 +215,6 @@ static int lpc32xx_adc_remove(struct platform_device *pdev)
>>
>> iio_device_unregister(iodev);
>> free_irq(irq, info);
>> - platform_set_drvdata(pdev, NULL);
>> clk_put(info->clk);
>> iounmap(info->adc_base);
>> iio_device_free(iodev);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2013-06-06 18:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-06 9:27 [PATCH 1/3] staging: iio: ad7606_par: Remove redundant platform_set_drvdata() Sachin Kamat
2013-06-06 9:27 ` [PATCH 2/3] staging: iio: spear_adc: " Sachin Kamat
2013-06-06 9:51 ` Stefan Roese
2013-06-06 9:27 ` [PATCH 3/3] staging: iio: lpc32xx_adc: " Sachin Kamat
2013-06-06 15:10 ` Roland Stigge
2013-06-06 18:49 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B0D9B0.3050306@kernel.org \
--to=jic23@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=stigge@antcom.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.