diff for duplicates of <51B181AC.3070400@ti.com> diff --git a/a/1.txt b/N1/1.txt index 589b283..75e8446 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -55,7 +55,7 @@ On Thursday 30 May 2013 03:04 PM, Tomi Valkeinen wrote: > + if (mgr->output) > + return -EINVAL; > + -> + if ((mgr->supported_outputs & dst->id) = 0) +> + if ((mgr->supported_outputs & dst->id) == 0) > + return -EINVAL; > + > + dst->manager = mgr; @@ -176,7 +176,7 @@ On Thursday 30 May 2013 03:04 PM, Tomi Valkeinen wrote: > + > + out = dssdev->output; > + -> + if (out = NULL) +> + if (out == NULL) > + return -ENODEV; > + > + mgr = omap_dss_get_overlay_manager(out->dispc_channel); @@ -197,12 +197,12 @@ On Thursday 30 May 2013 03:04 PM, Tomi Valkeinen wrote: > + > + out = dssdev->output; > + -> + if (out = NULL) +> + if (out == NULL) > + return; > + > + mgr = out->manager; > + -> + if (mgr = NULL) +> + if (mgr == NULL) > + return; > + > + dss_mgr_disconnect(mgr, out); @@ -213,11 +213,11 @@ On Thursday 30 May 2013 03:04 PM, Tomi Valkeinen wrote: > dssdriver->driver.bus = &dss_bus_type; > @@ -384,6 +424,10 @@ int omap_dss_register_driver(struct omap_dss_driver *dssdriver) > omapdss_default_get_recommended_bpp; -> if (dssdriver->get_timings = NULL) +> if (dssdriver->get_timings == NULL) > dssdriver->get_timings = omapdss_default_get_timings; -> + if (dssdriver->connect = NULL) +> + if (dssdriver->connect == NULL) > + dssdriver->connect = omapdss_default_connect; -> + if (dssdriver->disconnect = NULL) +> + if (dssdriver->disconnect == NULL) > + dssdriver->disconnect = omapdss_default_disconnect; I was wondering if these should be apis rather than driver ops. One diff --git a/a/content_digest b/N1/content_digest index 993fe15..d7c2ab0 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\01369906493-27538-13-git-send-email-tomi.valkeinen@ti.com\0" "From\0Archit Taneja <archit@ti.com>\0" "Subject\0Re: [PATCH 12/32] OMAPDSS: Implement display (dis)connect support\0" - "Date\0Fri, 07 Jun 2013 06:58:04 +0000\0" + "Date\0Fri, 7 Jun 2013 12:16:04 +0530\0" "To\0Tomi Valkeinen <tomi.valkeinen@ti.com>\0" "Cc\0linux-fbdev@vger.kernel.org" " linux-omap@vger.kernel.org\0" @@ -65,7 +65,7 @@ "> +\tif (mgr->output)\n" "> +\t\treturn -EINVAL;\n" "> +\n" - "> +\tif ((mgr->supported_outputs & dst->id) = 0)\n" + "> +\tif ((mgr->supported_outputs & dst->id) == 0)\n" "> +\t\treturn -EINVAL;\n" "> +\n" "> +\tdst->manager = mgr;\n" @@ -186,7 +186,7 @@ "> +\n" "> +\tout = dssdev->output;\n" "> +\n" - "> +\tif (out = NULL)\n" + "> +\tif (out == NULL)\n" "> +\t\treturn -ENODEV;\n" "> +\n" "> +\tmgr = omap_dss_get_overlay_manager(out->dispc_channel);\n" @@ -207,12 +207,12 @@ "> +\n" "> +\tout = dssdev->output;\n" "> +\n" - "> +\tif (out = NULL)\n" + "> +\tif (out == NULL)\n" "> +\t\treturn;\n" "> +\n" "> +\tmgr = out->manager;\n" "> +\n" - "> +\tif (mgr = NULL)\n" + "> +\tif (mgr == NULL)\n" "> +\t\treturn;\n" "> +\n" "> +\tdss_mgr_disconnect(mgr, out);\n" @@ -223,11 +223,11 @@ "> \tdssdriver->driver.bus = &dss_bus_type;\n" "> @@ -384,6 +424,10 @@ int omap_dss_register_driver(struct omap_dss_driver *dssdriver)\n" "> \t\t\tomapdss_default_get_recommended_bpp;\n" - "> \tif (dssdriver->get_timings = NULL)\n" + "> \tif (dssdriver->get_timings == NULL)\n" "> \t\tdssdriver->get_timings = omapdss_default_get_timings;\n" - "> +\tif (dssdriver->connect = NULL)\n" + "> +\tif (dssdriver->connect == NULL)\n" "> +\t\tdssdriver->connect = omapdss_default_connect;\n" - "> +\tif (dssdriver->disconnect = NULL)\n" + "> +\tif (dssdriver->disconnect == NULL)\n" "> +\t\tdssdriver->disconnect = omapdss_default_disconnect;\n" "\n" "I was wondering if these should be apis rather than driver ops. One \n" @@ -240,4 +240,4 @@ "\n" Archit -9c956fccd522c25cd748add9af46896927bf38fee2e777c54a4ccc0ebb46a7d0 +53fb0bc1b05e95a3e6b3f9c4cabd3eeee2b6913f08725905daccd5200834599c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.