From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58887) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkrMg-0003pA-4w for qemu-devel@nongnu.org; Fri, 07 Jun 2013 03:45:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UkrMf-0006OI-3n for qemu-devel@nongnu.org; Fri, 07 Jun 2013 03:45:38 -0400 Received: from cantor2.suse.de ([195.135.220.15]:41437 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkrMe-0006OB-To for qemu-devel@nongnu.org; Fri, 07 Jun 2013 03:45:37 -0400 Message-ID: <51B18F9A.7030900@suse.de> Date: Fri, 07 Jun 2013 09:45:30 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1370371954-8479-1-git-send-email-pbonzini@redhat.com> <51AF09FC.50308@suse.de> <51B13151.10709@redhat.com> In-Reply-To: <51B13151.10709@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, mst@redhat.com Am 07.06.2013 03:03, schrieb Paolo Bonzini: > Il 05/06/2013 05:50, Andreas F=E4rber ha scritto: >> Also I notice some patches are accessing parent fields directly - plea= se >> use BUS(), PCI_DEVICE() etc. to hide this. >=20 > I'm always using them. For example: >=20 > +static void intel_hda_instance_finalize(Object *obj) > +{ > + PCIDevice *pci =3D PCI_DEVICE(obj); > + IntelHDAState *d =3D DO_UPCAST(IntelHDAState, pci, pci); I'll comment inline then. :) Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg