From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59644)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UkrPX-0006KL-O5
	for qemu-devel@nongnu.org; Fri, 07 Jun 2013 03:48:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UkrPW-0007I1-V3
	for qemu-devel@nongnu.org; Fri, 07 Jun 2013 03:48:35 -0400
Received: from cantor2.suse.de ([195.135.220.15]:41519 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UkrPW-0007Hv-PH
	for qemu-devel@nongnu.org; Fri, 07 Jun 2013 03:48:34 -0400
Message-ID: <51B1904E.3090605@suse.de>
Date: Fri, 07 Jun 2013 09:48:30 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1370371954-8479-1-git-send-email-pbonzini@redhat.com>
	<1370371954-8479-2-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1370371954-8479-2-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 01/39] scsi: keep device alive while it has
 requests
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, mst@redhat.com

Am 04.06.2013 20:51, schrieb Paolo Bonzini:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  hw/scsi/scsi-bus.c | 4 ++++
>  1 file changed, 4 insertions(+)
>=20
> diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c
> index 53ea906..e443193 100644
> --- a/hw/scsi/scsi-bus.c
> +++ b/hw/scsi/scsi-bus.c
> @@ -516,6 +516,8 @@ SCSIRequest *scsi_req_alloc(const SCSIReqOps *reqop=
s, SCSIDevice *d,
>      req->status =3D -1;
>      req->sense_len =3D 0;
>      req->ops =3D reqops;
> +    object_ref(OBJECT(d));
> +    object_ref(OBJECT(req->bus->qbus.parent));

BusState *bus =3D BUS(req->bus);
...
object_ref(OBJECT(bus->parent));

Same below.

Andreas

>      trace_scsi_req_alloc(req->dev->id, req->lun, req->tag);
>      return req;
>  }
> @@ -1505,6 +1507,8 @@ void scsi_req_unref(SCSIRequest *req)
>          if (req->ops->free_req) {
>              req->ops->free_req(req);
>          }
> +        object_unref(OBJECT(req->dev));
> +        object_unref(OBJECT(bus->qbus.parent));
>          g_free(req);
>      }
>  }
>=20


--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg