From: Jerome Marchand <jmarchan@redhat.com>
To: Jiang Liu <liuj97@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nitin Gupta <ngupta@vflare.org>, Minchan Kim <minchan@kernel.org>,
Jiang Liu <jiang.liu@huawei.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v3 01/10] zram: avoid invalid memory access in zram_exit()
Date: Fri, 07 Jun 2013 11:29:20 +0200 [thread overview]
Message-ID: <51B1A7F0.8010406@redhat.com> (raw)
In-Reply-To: <1370534851-26056-2-git-send-email-jiang.liu@huawei.com>
On 06/06/2013 06:07 PM, Jiang Liu wrote:
> Memory for zram->disk object may have already been freed after returning
> from destroy_device(zram), then it's unsafe for zram_reset_device(zram)
> to access zram->disk again.
>
> We can't solve this bug by flipping the order of destroy_device(zram)
> and zram_reset_device(zram), that will cause deadlock issues to the
> zram sysfs handler.
>
> So fix it by holding an extra reference to zram->disk before calling
> destroy_device(zram).
>
> Signed-off-by: Jiang Liu <jiang.liu@huawei.com>
> Cc: stable@vger.kernel.org
Acked-by: Jerome Marchand <jmarchan@redhat.com>
next prev parent reply other threads:[~2013-06-07 9:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-06 16:07 [PATCH v2 00/10] Bugfixes and minor improvements for zram Jiang Liu
2013-06-06 16:07 ` [PATCH v3 01/10] zram: avoid invalid memory access in zram_exit() Jiang Liu
2013-06-07 7:58 ` Minchan Kim
2013-06-07 9:29 ` Jerome Marchand [this message]
2013-06-06 16:07 ` [PATCH v3 02/10] zram: use zram->lock to protect zram_free_page() in swap free notify path Jiang Liu
2013-06-07 8:05 ` Minchan Kim
2013-06-07 9:32 ` Jerome Marchand
2013-06-06 16:07 ` [PATCH v3 03/10] zram: destroy all devices on error recovery path in zram_init() Jiang Liu
2013-06-06 16:07 ` [PATCH v3 04/10] zram: avoid double free in function zram_bvec_write() Jiang Liu
2013-06-07 8:06 ` Minchan Kim
2013-06-06 16:07 ` [PATCH v3 05/10] zram: avoid access beyond the zram device Jiang Liu
2013-06-07 8:09 ` Minchan Kim
2013-06-07 9:40 ` Jerome Marchand
2013-06-07 9:43 ` Jiang Liu
2013-06-06 16:07 ` [PATCH v3 06/10] zram: protect sysfs handler from invalid memory access Jiang Liu
2013-06-07 9:41 ` Jerome Marchand
2013-06-06 16:07 ` [PATCH v3 07/10] zram: simplify and optimize dev_to_zram() Jiang Liu
2013-06-06 16:07 ` [PATCH v3 08/10] zram: kill unused zram_get_num_devices() Jiang Liu
2013-06-06 16:07 ` [PATCH v3 09/10] zram: optimize memory operations with clear_page()/copy_page() Jiang Liu
2013-06-06 16:07 ` [PATCH v3 10/10] zram: use atomic64_xxx() to replace zram_stat64_xxx() Jiang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B1A7F0.8010406@redhat.com \
--to=jmarchan@redhat.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jiang.liu@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuj97@gmail.com \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.