From: Jaehoon Chung <jh80.chung@samsung.com>
To: Jaehoon Chung <jh80.chung@samsung.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
'Chris Ball' <cjb@laptop.org>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCHv2] mmc: sdhci-s3c: fix the wrong register value when, clock is disabled
Date: Fri, 07 Jun 2013 20:39:14 +0900 [thread overview]
Message-ID: <51B1C662.3060405@samsung.com> (raw)
In-Reply-To: <51A2DCC4.2020307@samsung.com>
Dear Chris,
If you didn't have any comment, Could you merge this patch, plz?
Best Regards,
Jaehoon Chung
On 05/27/2013 01:10 PM, Jaehoon Chung wrote:
> When use the QUIRK_NONSTANDARD_CLOCK, then never set to 0 at clock control register.
> This patch is fixed this problem.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.co
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> Changelog v2:
> - Rebased at the latest mmc tree
>
> drivers/mmc/host/sdhci-s3c.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
> index 926aaf6..ce71f32 100644
> --- a/drivers/mmc/host/sdhci-s3c.c
> +++ b/drivers/mmc/host/sdhci-s3c.c
> @@ -297,8 +297,11 @@ static void sdhci_cmu_set_clock(struct sdhci_host *host, unsigned int clock)
> u16 clk = 0;
>
> /* don't bother if the clock is going off */
> - if (clock == 0)
> + if (clock == 0) {
> + sdhci_writew(host, 0, SDHCI_CLOCK_CONTROL);
> + host->clock = clock;
> return;
> + }
>
> sdhci_s3c_set_clock(host, clock);
>
>
next prev parent reply other threads:[~2013-06-07 11:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-27 4:10 [PATCHv2] mmc: sdhci-s3c: fix the wrong register value when, clock is disabled Jaehoon Chung
2013-06-07 11:39 ` Jaehoon Chung [this message]
2013-06-27 14:53 ` Chris Ball
2013-06-28 3:54 ` Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B1C662.3060405@samsung.com \
--to=jh80.chung@samsung.com \
--cc=cjb@laptop.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.