From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57759) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkwxJ-0007Ku-Q9 for qemu-devel@nongnu.org; Fri, 07 Jun 2013 09:43:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UkwxH-0006pZ-Ao for qemu-devel@nongnu.org; Fri, 07 Jun 2013 09:43:49 -0400 Received: from cantor2.suse.de ([195.135.220.15]:55792 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkwxH-0006p5-32 for qemu-devel@nongnu.org; Fri, 07 Jun 2013 09:43:47 -0400 Message-ID: <51B1E38F.70904@suse.de> Date: Fri, 07 Jun 2013 15:43:43 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1370602761-3566-1-git-send-email-armbru@redhat.com> <1370602761-3566-6-git-send-email-armbru@redhat.com> In-Reply-To: <1370602761-3566-6-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 5/5] trace-events: Fix up source file comments List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, stefanha@redhat.com Am 07.06.2013 12:59, schrieb Markus Armbruster: > They're all wrong since (at least) Paolo's big source tree > reorganization. Need to shuffle some event declarations around to > keep them under the correct source file comment. >=20 > Signed-off-by: Markus Armbruster > --- > trace-events | 162 ++++++++++++++++++++++++++++++++-------------------= -------- > 1 file changed, 87 insertions(+), 75 deletions(-) >=20 > diff --git a/trace-events b/trace-events > index e12d376..d95e903 100644 > --- a/trace-events > +++ b/trace-events > @@ -25,18 +25,14 @@ > # > # The should be a sprintf()-compatible format string. > =20 > -# qemu-malloc.c > -g_malloc(size_t size, void *ptr) "size %zu ptr %p" > -g_realloc(void *ptr, size_t size, void *newptr) "ptr %p size %zu newpt= r %p" > -g_free(void *ptr) "ptr %p" > - > -# osdep.c > +# util/oslib-win32.c > +# util/oslib-posix.c [snip] Thanks for taking time for this cleanup! I noticed before but haven't found the time myself so far. ;) If someone else feels like cleaning up, there's also quite a number of header files which annotate prototypes with now wrong source files. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg