From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shilimkar Subject: Re: [PATCH] cpuidle: fix ARCH_NEEDS_CPU_IDLE_COUPLED dependency warning Date: Fri, 7 Jun 2013 19:21:35 -0400 Message-ID: <51B26AFF.9080908@ti.com> References: <1370626856-2876-1-git-send-email-daniel.lezcano@linaro.org> <51B21D65.3040604@ti.com> <201306072121.58719.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from bear.ext.ti.com ([192.94.94.41]:60903 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754831Ab3FGXWN (ORCPT ); Fri, 7 Jun 2013 19:22:13 -0400 In-Reply-To: <201306072121.58719.arnd@arndb.de> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Arnd Bergmann Cc: Daniel Lezcano , rjw@sisk.pl, patches@linaro.org, linaro-kernel@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, Colin Cross On Friday 07 June 2013 03:21 PM, Arnd Bergmann wrote: > On Friday 07 June 2013, Santosh Shilimkar wrote: >>> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig >>> index f49cd51..831e89e 100644 >>> --- a/arch/arm/mach-omap2/Kconfig >>> +++ b/arch/arm/mach-omap2/Kconfig >>> @@ -83,7 +83,7 @@ config ARCH_OMAP4 >>> depends on ARCH_OMAP2PLUS >>> depends on ARCH_MULTI_V7 >>> select ARCH_HAS_OPP >>> - select ARCH_NEEDS_CPU_IDLE_COUPLED if SMP >>> + select ARCH_NEEDS_CPU_IDLE_COUPLED if (SMP && CPU_IDLE) >> >> I remember Colin mentioning about above dependency is taken care >> already in design [1] > > It's a matter of how it gets represented in Kconfig. Right now > the ARCH_NEEDS_CPU_IDLE_COUPLED symbol has a dependency on CPU_IDLE, > so we cannot select it if CPU_IDLE is not set (or get a build time > warning). > > I originally suggested removing the dependency, but Daniel preferred > to leave it there as an explicit dependency so it is required to > do this change instead. > I see. Thanks for clarifying. Regards, Santosh From mboxrd@z Thu Jan 1 00:00:00 1970 From: santosh.shilimkar@ti.com (Santosh Shilimkar) Date: Fri, 7 Jun 2013 19:21:35 -0400 Subject: [PATCH] cpuidle: fix ARCH_NEEDS_CPU_IDLE_COUPLED dependency warning In-Reply-To: <201306072121.58719.arnd@arndb.de> References: <1370626856-2876-1-git-send-email-daniel.lezcano@linaro.org> <51B21D65.3040604@ti.com> <201306072121.58719.arnd@arndb.de> Message-ID: <51B26AFF.9080908@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Friday 07 June 2013 03:21 PM, Arnd Bergmann wrote: > On Friday 07 June 2013, Santosh Shilimkar wrote: >>> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig >>> index f49cd51..831e89e 100644 >>> --- a/arch/arm/mach-omap2/Kconfig >>> +++ b/arch/arm/mach-omap2/Kconfig >>> @@ -83,7 +83,7 @@ config ARCH_OMAP4 >>> depends on ARCH_OMAP2PLUS >>> depends on ARCH_MULTI_V7 >>> select ARCH_HAS_OPP >>> - select ARCH_NEEDS_CPU_IDLE_COUPLED if SMP >>> + select ARCH_NEEDS_CPU_IDLE_COUPLED if (SMP && CPU_IDLE) >> >> I remember Colin mentioning about above dependency is taken care >> already in design [1] > > It's a matter of how it gets represented in Kconfig. Right now > the ARCH_NEEDS_CPU_IDLE_COUPLED symbol has a dependency on CPU_IDLE, > so we cannot select it if CPU_IDLE is not set (or get a build time > warning). > > I originally suggested removing the dependency, but Daniel preferred > to leave it there as an explicit dependency so it is required to > do this change instead. > I see. Thanks for clarifying. Regards, Santosh