From: Johannes Sixt <j6t@kdbg.org>
To: "Torsten Bögershausen" <tboegi@web.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] t0070: Use precondition CANNOTWRITE
Date: Sat, 08 Jun 2013 09:23:22 +0200 [thread overview]
Message-ID: <51B2DBEA.10205@kdbg.org> (raw)
In-Reply-To: <201306080851.17044.tboegi@web.de>
Am 08.06.2013 08:51, schrieb Torsten Bögershausen:
> Filesystems like VFAT or NTFS allow to create files regardless of
> the write permissions of the directory.
>
> Therefore "mktemp to unwritable directory" in t0700 will always fail on
> Windows using NTFS.
> This TC has been disabled for MINGW, and needs to be disabled for CYGWIN.
>
> Use the precondition CANNOTWRITE which is probing the file system and
> works for MINGW, CYGWIN and even for Linux using VFAT.
Shouldn't it be a matter of
-test_expect_success POSIXPERM 'mktemp to unwritable directory prints filename' '
+test_expect_success SANITY 'mktemp to unwritable directory prints filename' '
It probably wouldn't catch Linux VFAT, but there're already a lot of
tests that don't pass on Linux VFAT.
-- Hannes
prev parent reply other threads:[~2013-06-08 7:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-08 6:51 [PATCH] t0070: Use precondition CANNOTWRITE Torsten Bögershausen
2013-06-08 7:23 ` Johannes Sixt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B2DBEA.10205@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.