All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Chen Gang <gang.chen@asianux.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	"mingo@redhat.com" <mingo@redhat.com>,
	the arch/x86 maintainers <x86@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Paul McKenney <paulmck@linux.vnet.ibm.com>,
	shli@fusionio.com, "dhowells@redhat.com" <dhowells@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Linux-Arch <linux-arch@vger.kernel.org>
Subject: Re: [PATCH] arch: x86: include: asm: need 'unsigned' type cast for atomic_clear_mask()
Date: Sat, 08 Jun 2013 00:31:19 -0700	[thread overview]
Message-ID: <51B2DDC7.4070107@zytor.com> (raw)
In-Reply-To: <51B2CF75.1090207@asianux.com>

On 06/07/2013 11:30 PM, Chen Gang wrote:
> 
> atomic_set_mask() has already have 'unsigned' type case, and
> atomic_clear_mask() is the pair of atomic_set_mask().
> 
> So it also need 'unsigned' type case.
> 

Pray tell, in what situation does this matter?  The only reason I can
think of is if "mask" is actually a long...

	-hpa

  reply	other threads:[~2013-06-08  7:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-08  6:30 [PATCH] arch: x86: include: asm: need 'unsigned' type cast for atomic_clear_mask() Chen Gang
2013-06-08  7:31 ` H. Peter Anvin [this message]
2013-06-08  8:02   ` Chen Gang
2013-06-08  8:25     ` Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51B2DDC7.4070107@zytor.com \
    --to=hpa@zytor.com \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=gang.chen@asianux.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=shli@fusionio.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.