All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oliver Hartkopp <socketcan@hartkopp.net>
To: uescher <linux-can_ger.kernel.org@myvdr.de>
Cc: linux-can@vger.kernel.org
Subject: Re: [PATCH 1/1 V2] slcanpty: Improve the data handling from pty2can() to avoid, incomplete messages in further processing
Date: Sat, 08 Jun 2013 13:18:41 +0200	[thread overview]
Message-ID: <51B31311.6080606@hartkopp.net> (raw)
In-Reply-To: <51AA491A.7060307@myvdr.de>

On 01.06.2013 21:18, uescher wrote:
> slcanpty: Improve the data handling from pty2can() to avoid
>  incomplete messages in further processing
> 
> This Patch ensure that we have minimum one complete SLCAN messages from pty in
> our buf[]
> before we start the processing.
> Leave framgents of an messages in the buf[] and wait with processing until we
> have a '\r' in the buf[].
> 
> Signed-off-by: Ulrich Escher <git@myvdr.de>
> 
> 
> 

Hi Ulrich,

thanks for the fix!

Indeed I needed some time to get the point %-)

I removed all the debug stuff and added some comments to reduce the time to
get the point the next time i look into that code.

I changed the for() statement with the break to a simpler implementation.

Please check out the updated version which should do the same as your patch.

Best regards,
Oliver



  reply	other threads:[~2013-06-08 11:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-01 19:18 [PATCH 1/1 V2] slcanpty: Improve the data handling from pty2can() to avoid, incomplete messages in further processing uescher
2013-06-08 11:18 ` Oliver Hartkopp [this message]
2013-06-15 20:39   ` uescher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51B31311.6080606@hartkopp.net \
    --to=socketcan@hartkopp.net \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-can_ger.kernel.org@myvdr.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.