All of lore.kernel.org
 help / color / mirror / Atom feed
From: Huang Shijie <b32955@freescale.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: gregkh@linuxfoundation.org, shawn.guo@linaro.org,
	linux-serial@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] serial: imx: enable the clocks for console
Date: Sun, 9 Jun 2013 10:17:51 +0800	[thread overview]
Message-ID: <51B3E5CF.4010202@freescale.com> (raw)
In-Reply-To: <CAOMZO5A4SPFv1NopdGrN9nX-XSpZy5Cw1CLp3E95mRP8O=rhLQ@mail.gmail.com>

于 2013年06月08日 21:11, Fabio Estevam 写道:
> Hi Huang,
>
> On Sat, Jun 8, 2013 at 5:04 AM, Huang Shijie<b32955@freescale.com>  wrote:
>
>> +       if (!uart_console(port)) {
>> +               retval = clk_prepare_enable(sport->clk_per);
>> +               if (retval)
>> +                       goto error_out1;
>> +               retval = clk_prepare_enable(sport->clk_ipg);
>> +               if (retval)
>> +                       goto error_out1;
> Here you should not jump to "error_out1".
>
> You should jump to a different label and disable the sport->clk_per clock.
yes. you are right.
I will fix it in the patch "serial: imx: enable the clocks for console"

thanks
Huang Shijie
> This was also wrong in your previous patch.
>


--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: b32955@freescale.com (Huang Shijie)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] serial: imx: enable the clocks for console
Date: Sun, 9 Jun 2013 10:17:51 +0800	[thread overview]
Message-ID: <51B3E5CF.4010202@freescale.com> (raw)
In-Reply-To: <CAOMZO5A4SPFv1NopdGrN9nX-XSpZy5Cw1CLp3E95mRP8O=rhLQ@mail.gmail.com>

? 2013?06?08? 21:11, Fabio Estevam ??:
> Hi Huang,
>
> On Sat, Jun 8, 2013 at 5:04 AM, Huang Shijie<b32955@freescale.com>  wrote:
>
>> +       if (!uart_console(port)) {
>> +               retval = clk_prepare_enable(sport->clk_per);
>> +               if (retval)
>> +                       goto error_out1;
>> +               retval = clk_prepare_enable(sport->clk_ipg);
>> +               if (retval)
>> +                       goto error_out1;
> Here you should not jump to "error_out1".
>
> You should jump to a different label and disable the sport->clk_per clock.
yes. you are right.
I will fix it in the patch "serial: imx: enable the clocks for console"

thanks
Huang Shijie
> This was also wrong in your previous patch.
>

  parent reply	other threads:[~2013-06-09  2:14 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-04  1:59 [PATCH V2] serial: imx: enable the clocks only when the uart is used Huang Shijie
2013-06-04  1:59 ` Huang Shijie
2013-06-08  6:01 ` Shawn Guo
2013-06-08  6:01   ` Shawn Guo
2013-06-08  6:22   ` Huang Shijie
2013-06-08  6:22     ` Huang Shijie
2013-06-08  6:23     ` Shawn Guo
2013-06-08  6:23       ` Shawn Guo
2013-06-08  8:04       ` [PATCH] serial: imx: enable the clocks for console Huang Shijie
2013-06-08  8:04         ` Huang Shijie
2013-06-08 13:11         ` Fabio Estevam
2013-06-08 13:11           ` Fabio Estevam
2013-06-09  2:01           ` [PATCH v2] " Huang Shijie
2013-06-09  2:01             ` Huang Shijie
2013-06-09  8:34             ` Shawn Guo
2013-06-09  8:34               ` Shawn Guo
2013-06-09 13:05               ` Shawn Guo
2013-06-09 13:05                 ` Shawn Guo
2013-06-09 17:26                 ` Greg KH
2013-06-09 17:26                   ` Greg KH
2013-06-10  0:55                   ` Shawn Guo
2013-06-10  0:55                     ` Shawn Guo
2013-06-09  2:17           ` Huang Shijie [this message]
2013-06-09  2:17             ` [PATCH] " Huang Shijie
2013-06-08 11:56       ` Re[2]: [PATCH V2] serial: imx: enable the clocks only when the uart is used Alexander Shiyan
2013-06-08 11:56         ` Alexander Shiyan
2013-06-08  8:15     ` Russell King - ARM Linux
2013-06-08  8:15       ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51B3E5CF.4010202@freescale.com \
    --to=b32955@freescale.com \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.