Re: [PATCH] sh_eth: Fix warnings on 64-bit.

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 06/08/2013 10:41 AM, David Miller wrote:

> Don't cast a plain integer to a pointer.

> drivers/net/ethernet/renesas/sh_eth.c: In function ‘sh_eth_chip_reset_giga’:
> drivers/net/ethernet/renesas/sh_eth.c:482:22: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> drivers/net/ethernet/renesas/sh_eth.c:483:22: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> drivers/net/ethernet/renesas/sh_eth.c:492:22: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> drivers/net/ethernet/renesas/sh_eth.c:493:22: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

> Signed-off-by: David S. Miller <davem@davemloft.net>
> ---

> Applied to net-next.

>   drivers/net/ethernet/renesas/sh_eth.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> index cff6971..43d8490 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
> @@ -469,7 +469,7 @@ static struct sh_eth_cpu_data sh7757_data = {
>   	.rpadir_value   = 2 << 16,
>   };
>
> -#define SH_GIGA_ETH_BASE	0xfee00000
> +#define SH_GIGA_ETH_BASE	0xfee00000UL
>   #define GIGA_MALR(port)		(SH_GIGA_ETH_BASE + 0x800 * (port) + 0x05c8)
>   #define GIGA_MAHR(port)		(SH_GIGA_ETH_BASE + 0x800 * (port) + 0x05c0)
>   static void sh_eth_chip_reset_giga(struct net_device *ndev)

    Fixing up another dirty hack? This driver is just an abomination... :-)

WBR, Sergei