From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37762)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Ulr6L-0004xn-S3
	for qemu-devel@nongnu.org; Sun, 09 Jun 2013 21:40:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Ulr6L-0003D4-1D
	for qemu-devel@nongnu.org; Sun, 09 Jun 2013 21:40:53 -0400
Received: from cantor2.suse.de ([195.135.220.15]:54838 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Ulr6K-0003Cz-Pr
	for qemu-devel@nongnu.org; Sun, 09 Jun 2013 21:40:52 -0400
Message-ID: <51B52E9F.2010406@suse.de>
Date: Mon, 10 Jun 2013 03:40:47 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1370609900-21998-1-git-send-email-afaerber@suse.de>
	<1370609900-21998-6-git-send-email-afaerber@suse.de>
	<1370828236.21655.27.camel@liguang.fnst.cn.fujitsu.com>
In-Reply-To: <1370828236.21655.27.camel@liguang.fnst.cn.fujitsu.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 05/12] kvm/i8254: QOM'ify some more
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: li guang <lig.fnst@cn.fujitsu.com>
Cc: qemu-devel@nongnu.org, anthony@codemonkey.ws

Am 10.06.2013 03:37, schrieb li guang:
> =E5=9C=A8 2013-06-07=E4=BA=94=E7=9A=84 14:58 +0200=EF=BC=8CAndreas F=C3=
=A4rber=E5=86=99=E9=81=93=EF=BC=9A
>> diff --git a/hw/i386/kvm/i8254.c b/hw/i386/kvm/i8254.c
>> index da90711..4ac5551 100644
>> --- a/hw/i386/kvm/i8254.c
>> +++ b/hw/i386/kvm/i8254.c
[...]
>> @@ -70,7 +73,7 @@ static void kvm_pit_update_clock_offset(KVMPITState =
*s)
>> =20
>>  static void kvm_pit_get(PITCommonState *pit)
>>  {
>> -    KVMPITState *s =3D DO_UPCAST(KVMPITState, pit, pit);
>> +    KVMPITState *s =3D KVM_PIT(pit);
>=20
> maybe we should keep the coding-style
> either func(...) or func (...),
> these patches blend them.

Where exactly? Only malc's audio files should have the func (...) style.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg