From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@kernel.org>
Cc: tiwai@suse.de, Qiao Zhou <zhouqiao@marvell.com>,
alsa-devel@alsa-project.org, zhangfei.gao@gmail.com
Subject: Re: [PATCH] ASoC: dmaengine: add runtime status checking in dmaengine_pcm_dma_complete
Date: Mon, 10 Jun 2013 12:46:52 +0200 [thread overview]
Message-ID: <51B5AE9C.6020207@metafoo.de> (raw)
In-Reply-To: <20130610093155.GK31367@sirena.org.uk>
On 06/10/2013 11:31 AM, Mark Brown wrote:
> On Sun, Jun 09, 2013 at 03:51:09PM +0200, Lars-Peter Clausen wrote:
>> On 06/09/2013 03:37 PM, Lars-Peter Clausen wrote:
>
>>> I haven't see the original patch, but the proper solution to this problem
>>> should be to add a check to snd_dmaengine_pcm_close() to see if the DMA is
>>> still running.
>
>> Ok, since this will never happen, I suppose the problem is rather that the DMA
>> callback is called after dma_terminate_all() has been called. Which sounds like
>> it is a bug in the dmaengine driver. And this will likely also be a problem for
>> other users of that dmaengine driver and not only the ASoC driver, so it should
>> be fixed in the dmaengine driver.
>
> Just to clarify what is it makes you say that this will never happen?
At least that is my understanding of snd_pcm_release_substream(), that it
will first make sure that the stream is stopped, by calling snd_pcm_drop(),
before closing the stream.
- Lars
next prev parent reply other threads:[~2013-06-10 10:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1370606249-19955-1-git-send-email-zhouqiao@marvell.com>
2013-06-07 14:34 ` [PATCH] ASoC: dmaengine: add runtime status checking in dmaengine_pcm_dma_complete Mark Brown
2013-06-09 13:37 ` Lars-Peter Clausen
2013-06-09 13:51 ` Lars-Peter Clausen
2013-06-10 9:31 ` Mark Brown
2013-06-10 10:46 ` Lars-Peter Clausen [this message]
2013-06-12 7:43 ` Vinod Koul
2013-06-12 12:15 ` Lars-Peter Clausen
2013-06-12 14:39 ` Mark Brown
2013-06-14 9:10 ` Qiao Zhou
[not found] ` <51B2EC7A.8090309@marvell.com>
2013-06-10 9:30 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B5AE9C.6020207@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=tiwai@suse.de \
--cc=zhangfei.gao@gmail.com \
--cc=zhouqiao@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.