All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Axel Lin <axel.lin@ingics.com>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] ASoC: ssm2518: Fix trivial typo in checking tx_mask and rx_mask values
Date: Mon, 10 Jun 2013 16:26:45 +0200	[thread overview]
Message-ID: <51B5E225.2020003@metafoo.de> (raw)
In-Reply-To: <1370874233.25883.1.camel@phoenix>

On 06/10/2013 04:23 PM, Axel Lin wrote:
> Otherwise, ssm2518_set_tdm_slot() always returns error if slots != 0.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Acked-by: Lars-Peter Clausen <lars@metafoo.de>

Thanks.

> ---
>  sound/soc/codecs/ssm2518.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/ssm2518.c b/sound/soc/codecs/ssm2518.c
> index a76b341..f4883d9 100644
> --- a/sound/soc/codecs/ssm2518.c
> +++ b/sound/soc/codecs/ssm2518.c
> @@ -538,7 +538,7 @@ static int ssm2518_set_tdm_slot(struct snd_soc_dai *dai, unsigned int tx_mask,
>  			SSM2518_REG_SAI_CTRL1, SSM2518_SAI_CTRL1_SAI_MASK,
>  			SSM2518_SAI_CTRL1_SAI_I2S);
>  
> -	if (tx_mask == 0 || tx_mask != 0)
> +	if (tx_mask == 0 || rx_mask != 0)
>  		return -EINVAL;
>  
>  	if (slots == 1) {

  reply	other threads:[~2013-06-10 14:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-10 14:23 [PATCH] ASoC: ssm2518: Fix trivial typo in checking tx_mask and rx_mask values Axel Lin
2013-06-10 14:26 ` Lars-Peter Clausen [this message]
2013-06-10 17:06 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51B5E225.2020003@metafoo.de \
    --to=lars@metafoo.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=axel.lin@ingics.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.