All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oded Gabbay <ogabbay@advaoptical.com>
To: Dirk Behme <dirk.behme@de.bosch.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"cjb@laptop.org" <cjb@laptop.org>,
	"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
	"rob@landley.net" <rob@landley.net>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree-discuss@lists.ozlabs.org"
	<devicetree-discuss@lists.ozlabs.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: Re: [PATCH 3/3] MMC: FSL SDHC: Add support for hard-wired (permanent) card. Kernel version 3.4.47
Date: Mon, 10 Jun 2013 19:44:38 +0300	[thread overview]
Message-ID: <51B60276.5040002@advaoptical.com> (raw)
In-Reply-To: <51B5D7F0.4050708@advaoptical.com>

Hi All,

Just noticed that 3.4.47/8 doesn't have the mmc_of_parse (compared to 
3.9.4).
Therefore, I will not use it and just fix the code to recognize the 
property "non-removable"

Best regards,
Oded

On 06/10/2013 04:43 PM, Oded Gabbay wrote:
> Hi Dirk,
>
> You are absolutely right.
> I will revise my patch series to reflect the change.
> Basically, I will call the generic mmc_of_parse from the probe 
> function of Freescale's driver.
> That will handle all the additional capabilities.
>
> Thanks
> Oded
>
> On 06/10/2013 09:29 AM, Dirk Behme wrote:
>> On 02.06.2013 08:38, Oded Gabbay wrote:
>>> This patch adds support of recognizing hard-wired (permanent) cards
>>> to Freescale's SDHC host driver. This is done by adding the option
>>> "fsl,card-wired" to the SDHC device-tree entry. Detection of this
>>> option is done in the probe function. Update documentation in file
>>> fsl-esdhc.txt
>>
>> Why don't you want to introduce "fsl,card-wired"? Why don't you use 
>> "non-removable"?
>>
>> To my understanding the patch
>>
>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=7f217794ffa72f208a250b79ab0b7ea3de19677f 
>>
>>
>> explicitly removed "fsl,card-wired". So I don't think re-introducing 
>> it is a good idea?
>>
>> Best regards
>>
>> Dirk
>


      reply	other threads:[~2013-06-10 16:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-02  6:38 [PATCH 3/3] MMC: FSL SDHC: Add support for hard-wired (permanent) card. Kernel version 3.4.47 Oded Gabbay
2013-06-02  6:38 ` Oded Gabbay
2013-06-10  6:29 ` Dirk Behme
2013-06-10 13:43   ` Oded Gabbay
2013-06-10 16:44     ` Oded Gabbay [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51B60276.5040002@advaoptical.com \
    --to=ogabbay@advaoptical.com \
    --cc=cjb@laptop.org \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=dirk.behme@de.bosch.com \
    --cc=grant.likely@secretlab.ca \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=rob@landley.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.