From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH net v2 01/03] vxlan: only migrate dynamic FDB entries Date: Tue, 11 Jun 2013 00:27:02 +0400 Message-ID: <51B63696.7020000@cogentembedded.com> References: <20130610195822.888424947@vyatta.com> <20130610131317.0c17ed0d@nehalam.linuxnetplumber.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, netdev@vger.kernel.org To: Stephen Hemminger Return-path: Received: from mail-lb0-f174.google.com ([209.85.217.174]:46829 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750929Ab3FJU1H (ORCPT ); Mon, 10 Jun 2013 16:27:07 -0400 Received: by mail-lb0-f174.google.com with SMTP id x10so4636399lbi.5 for ; Mon, 10 Jun 2013 13:27:04 -0700 (PDT) In-Reply-To: <20130610131317.0c17ed0d@nehalam.linuxnetplumber.net> Sender: netdev-owner@vger.kernel.org List-ID: Hello. On 06/11/2013 12:13 AM, Stephen Hemminger wrote: > Only migrate dynamic forwarding table entries, don't modify > static entries. If packet received from incorrect source IP address > assume it is an imposter and drop it. > Signed-off-by: Stephen Hemminger > --- > Should go to -stable as well. > --- a/drivers/net/vxlan.c 2013-06-06 08:27:07.499595174 -0700 > +++ b/drivers/net/vxlan.c 2013-06-06 09:38:54.291654035 -0700 > @@ -603,9 +603,10 @@ skip: > > /* Watch incoming packets to learn mapping between Ethernet address > * and Tunnel endpoint. > + * Return true if packet is bogus and should be droppped. > */ > -static void vxlan_snoop(struct net_device *dev, > - __be32 src_ip, const u8 *src_mac) > +static bool vxlan_snoop(struct net_device *dev, > + __be32 src_ip, const u8 *src_mac) Not clear why you changed the indentation of the second line... WBR, Sergei