From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58534)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Um9xD-00076h-No
	for qemu-devel@nongnu.org; Mon, 10 Jun 2013 17:48:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Um9xC-0001CA-Ru
	for qemu-devel@nongnu.org; Mon, 10 Jun 2013 17:48:43 -0400
Received: from cantor2.suse.de ([195.135.220.15]:45927 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Um9xC-0001C1-Kh
	for qemu-devel@nongnu.org; Mon, 10 Jun 2013 17:48:42 -0400
Message-ID: <51B649B7.1090707@suse.de>
Date: Mon, 10 Jun 2013 23:48:39 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1370805206-26574-1-git-send-email-afaerber@suse.de>
	<1370805206-26574-10-git-send-email-afaerber@suse.de>
In-Reply-To: <1370805206-26574-10-git-send-email-afaerber@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH qom-cpu 09/59] cpus: Simplify hw_error()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>, liguang <lig.fnst@cn.fujitsu.com>

Am 09.06.2013 21:12, schrieb Andreas F=C3=A4rber:
> Use new qemu_for_each_cpu().
>=20
> Signed-off-by: Andreas F=C3=A4rber <afaerber@suse.de>
> ---
>  cpus.c | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
>=20
> diff --git a/cpus.c b/cpus.c
> index 1975c5c..9195bc3 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -386,21 +386,22 @@ void configure_icount(const char *option)
>  }
> =20
>  /***********************************************************/
> +
> +static void hw_one_error(CPUState *cpu, void *data)
> +{
> +    fprintf(stderr, "CPU #%d:\n", cpu->cpu_index);
> +    cpu_dump_state(cpu->env_ptr, stderr, fprintf, CPU_DUMP_FPU);

This env_ptr usage is dangerous since as void* it bypasses all argument
type checks - luckily 18/59 does convert it.

If we want to go with qemu_for_each_cpu(), I better add a temporary
CPUArchState *env variable.

Andreas

> +}
> +
>  void hw_error(const char *fmt, ...)
>  {
>      va_list ap;
> -    CPUArchState *env;
> -    CPUState *cpu;
> =20
>      va_start(ap, fmt);
>      fprintf(stderr, "qemu: hardware error: ");
>      vfprintf(stderr, fmt, ap);
>      fprintf(stderr, "\n");
> -    for (env =3D first_cpu; env !=3D NULL; env =3D env->next_cpu) {
> -        cpu =3D ENV_GET_CPU(env);
> -        fprintf(stderr, "CPU #%d:\n", cpu->cpu_index);
> -        cpu_dump_state(env, stderr, fprintf, CPU_DUMP_FPU);
> -    }
> +    qemu_for_each_cpu(hw_one_error, NULL);
>      va_end(ap);
>      abort();
>  }
>=20


--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg