From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Subject: Re: [Qemu-devel] [PATCH qom-cpu 02/59] kvm: Change cpu_synchronize_state() argument to CPUState Date: Tue, 11 Jun 2013 01:23:17 +0200 Message-ID: <51B65FE5.4040203@suse.de> References: <1370805206-26574-1-git-send-email-afaerber@suse.de> <1370805206-26574-3-git-send-email-afaerber@suse.de> <1370829626.21655.34.camel@liguang.fnst.cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Alexander Graf , KVM , Gleb Natapov , Marcelo Tosatti , Markus Armbruster , qemu-devel@nongnu.org, qemu-ppc , Luiz Capitulino , Richard Henderson , Paolo Bonzini To: li guang Return-path: Received: from cantor2.suse.de ([195.135.220.15]:48292 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752546Ab3FJXXW (ORCPT ); Mon, 10 Jun 2013 19:23:22 -0400 In-Reply-To: <1370829626.21655.34.camel@liguang.fnst.cn.fujitsu.com> Sender: kvm-owner@vger.kernel.org List-ID: Am 10.06.2013 04:00, schrieb li guang: > =E5=9C=A8 2013-06-09=E6=97=A5=E7=9A=84 21:12 +0200=EF=BC=8CAndreas F=C3= =A4rber=E5=86=99=E9=81=93=EF=BC=9A >> Change Monitor::mon_cpu to CPUState as well. >> In cpu_sychronize_all_states() use qemu_for_each_cpu() now. >=20 > Oh, s/sychronize/synchronize =46ixed, thanks for noticing! > with that, > Reviewed-by: liguang Thanks. Unfortunately this patch touches on the question of what to do with CPU loops, so I'll wait for Markus and Gleb/Paolo to weigh in. >> In dump_init() use cpu_synchronize_all_states(). Was obsoleted by having extracted that hunk into my preceding series: http://patchwork.ozlabs.org/patch/250060/ Andreas >> >> Signed-off-by: Andreas F=C3=A4rber >> --- >> cpus.c | 13 +++++++------ >> gdbstub.c | 8 ++++---- >> hw/i386/kvm/apic.c | 2 +- >> hw/i386/kvmvapic.c | 4 ++-- >> hw/misc/vmport.c | 2 +- >> hw/ppc/ppce500_spin.c | 2 +- >> include/sysemu/kvm.h | 4 ++-- >> monitor.c | 6 +++--- >> target-i386/helper.c | 4 ++-- >> target-i386/kvm.c | 2 +- >> target-ppc/mmu-hash64.c | 2 +- >> target-ppc/translate.c | 2 +- >> target-s390x/kvm.c | 9 +++++---- >> 13 files changed, 31 insertions(+), 29 deletions(-) --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3= =BCrnberg From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51266) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UmBQt-0006sh-52 for qemu-devel@nongnu.org; Mon, 10 Jun 2013 19:23:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UmBQn-0004fj-IB for qemu-devel@nongnu.org; Mon, 10 Jun 2013 19:23:27 -0400 Message-ID: <51B65FE5.4040203@suse.de> Date: Tue, 11 Jun 2013 01:23:17 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1370805206-26574-1-git-send-email-afaerber@suse.de> <1370805206-26574-3-git-send-email-afaerber@suse.de> <1370829626.21655.34.camel@liguang.fnst.cn.fujitsu.com> In-Reply-To: <1370829626.21655.34.camel@liguang.fnst.cn.fujitsu.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-cpu 02/59] kvm: Change cpu_synchronize_state() argument to CPUState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: li guang Cc: KVM , Gleb Natapov , Markus Armbruster , Marcelo Tosatti , qemu-devel@nongnu.org, Alexander Graf , qemu-ppc , Paolo Bonzini , Luiz Capitulino , Richard Henderson Am 10.06.2013 04:00, schrieb li guang: > =E5=9C=A8 2013-06-09=E6=97=A5=E7=9A=84 21:12 +0200=EF=BC=8CAndreas F=C3= =A4rber=E5=86=99=E9=81=93=EF=BC=9A >> Change Monitor::mon_cpu to CPUState as well. >> In cpu_sychronize_all_states() use qemu_for_each_cpu() now. >=20 > Oh, s/sychronize/synchronize Fixed, thanks for noticing! > with that, > Reviewed-by: liguang Thanks. Unfortunately this patch touches on the question of what to do with CPU loops, so I'll wait for Markus and Gleb/Paolo to weigh in. >> In dump_init() use cpu_synchronize_all_states(). Was obsoleted by having extracted that hunk into my preceding series: http://patchwork.ozlabs.org/patch/250060/ Andreas >> >> Signed-off-by: Andreas F=C3=A4rber >> --- >> cpus.c | 13 +++++++------ >> gdbstub.c | 8 ++++---- >> hw/i386/kvm/apic.c | 2 +- >> hw/i386/kvmvapic.c | 4 ++-- >> hw/misc/vmport.c | 2 +- >> hw/ppc/ppce500_spin.c | 2 +- >> include/sysemu/kvm.h | 4 ++-- >> monitor.c | 6 +++--- >> target-i386/helper.c | 4 ++-- >> target-i386/kvm.c | 2 +- >> target-ppc/mmu-hash64.c | 2 +- >> target-ppc/translate.c | 2 +- >> target-s390x/kvm.c | 9 +++++---- >> 13 files changed, 31 insertions(+), 29 deletions(-) --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg