From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49817) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UmDhm-0004dA-D2 for qemu-devel@nongnu.org; Mon, 10 Jun 2013 21:49:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UmDhf-00044c-VI for qemu-devel@nongnu.org; Mon, 10 Jun 2013 21:49:02 -0400 Received: from [222.73.24.84] (port=1706 helo=song.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UmDhf-00044H-KY for qemu-devel@nongnu.org; Mon, 10 Jun 2013 21:48:55 -0400 Message-ID: <51B681F8.2070404@cn.fujitsu.com> Date: Tue, 11 Jun 2013 09:48:40 +0800 From: Qiao Nuohan MIME-Version: 1.0 References: <1369709437-24969-1-git-send-email-qiaonuohan@cn.fujitsu.com> <51AE946F.8040108@cn.fujitsu.com> <20130604221541.75bef4dd@redhat.com> <51B536C7.5050300@cn.fujitsu.com> <20130610085425.1a9bef34@redhat.com> In-Reply-To: <20130610085425.1a9bef34@redhat.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-1; format=flowed Subject: Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: zhangxh@cn.fujitsu.com, qemu-devel@nongnu.org, armbru@redhat.com, kumagai-atsushi@mxc.nes.nec.co.jp, anderson@redhat.com, Amos , afaerber@suse.de On 06/10/2013 08:54 PM, Luiz Capitulino wrote: > On Mon, 10 Jun 2013 10:15:35 +0800 > Qiao Nuohan wrote: > >> On 06/05/2013 10:15 AM, Luiz Capitulino wrote: >>> I can review it until the end of this week. If this series is adding a new >>> argument (which I believe is what it does) then there's only two ways >>> to get this merged: either we wait for full introspection or you add this >>> feature as a new command. >>> >>> I'd prefer to wait for full introspection, but it depends how long it's >>> going to take to get it merged and how much time you're willing to wait. >>> >>> Amos, can you give us an update on that work? >> >> Hi Luiz, >> >> I would like to get these patches reviewed first. If introspection won't take >> too much time, I will choose to wait. However, I cannot figure out how long it >> will take, why not get the parts not related to introspection settled first? > > What do you mean by "settled"? We can keep the review cycle going, but to > merge this we have two options: we wait for the full introspection or we > make this a different command. Sorry for confusing you. I mean "reviewed enough" here. If it won't take several months, I have no doubt about waiting for introspection. I just want these patches reviewed first, then I may get these patches ready for merging soon after introspection support. > >> Seems Amos's draft will not change qapi-schema.json. > > The point of Amos series is discovery, not conflicts. If we merge your > series w/o introspection support, then it's impossible for a mngt app like > libvirt to know whether or not a given QEMU version supports your new > argument. > Thanks for your explanation. > -- Regards Qiao Nuohan