Re: [PATCH 8/9] mpt2sas: Enable new EH timeout handler

[Hannes Reinecke <hare@suse.de>]

On 06/10/2013 05:31 PM, Jörn Engel wrote:
> On Mon, 10 June 2013 09:40:57 +0200, Hannes Reinecke wrote:
>>
>> Signed-off-by: Hannes Reinecke <hare@suse.de>
>> ---
>>  drivers/scsi/mpt2sas/mpt2sas_scsih.c | 11 +++++++++++
>>  1 file changed, 11 insertions(+)
>>
>> diff --git a/drivers/scsi/mpt2sas/mpt2sas_scsih.c b/drivers/scsi/mpt2sas/mpt2sas_scsih.c
>> index c6bdc92..47fc66c 100644
>> --- a/drivers/scsi/mpt2sas/mpt2sas_scsih.c
>> +++ b/drivers/scsi/mpt2sas/mpt2sas_scsih.c
>> @@ -2565,6 +2565,16 @@ _scsih_tm_display_info(struct MPT2SAS_ADAPTER *ioc, struct scsi_cmnd *scmd)
>>  }
>>  
>>  /**
>> + * _scsih_timed_out - eh timeout handler
>> + * @scmd: pointer to scsi command object
>> + */
>> +static enum blk_eh_timer_return
>> +_scsih_timed_out(struct scsi_cmnd *scmd)
>> +{
>> +	return scsi_abort_command(scmd);
>> +}
> 
> Why did you create this function and not do the following?
> +	.eh_timed_out			= scsi_abort_command,
> 
Good point.

That function was required for an earlier version (where
I had 'void scsi_abort_command()').
So yeah, that function isn't required.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html