From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sylwester Nawrocki Subject: Re: [PATCH] ARM: dts: Removing pdma for SSDK5440 Date: Tue, 11 Jun 2013 10:49:33 +0200 Message-ID: <51B6E49D.7000408@samsung.com> References: <109601ce6679$fef2e410$fcd8ac30$%kim@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout1.w1.samsung.com ([210.118.77.11]:21573 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752646Ab3FKIth (ORCPT ); Tue, 11 Jun 2013 04:49:37 -0400 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MO800CKI0CPOD70@mailout1.w1.samsung.com> for linux-samsung-soc@vger.kernel.org; Tue, 11 Jun 2013 09:49:35 +0100 (BST) In-reply-to: <109601ce6679$fef2e410$fcd8ac30$%kim@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Kukjin Kim Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, 'Giridhar Maruthy' On 06/11/2013 10:02 AM, Kukjin Kim wrote: > From: Giridhar Maruthy > > Since the pdma works only in secure mode, accessing the same > in hypervisor mode gives an abort. As we are not using pdma > anywhere (including spi), removing the same. > > Signed-off-by: Giridhar Maruthy > Signed-off-by: Kukjin Kim I was wondering, wouldn't it be sufficient to add status = "disabled"; in those pdma nodes, to avoid re-adding them in future ? As for the DMA properties in the spi device nodes, they should indeed be removed, as generic DMA bindings would be used instead. Regards, Sylwester > --- > arch/arm/boot/dts/exynos5440.dtsi | 24 ------------------------ > 1 file changed, 24 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5440.dtsi b/arch/arm/boot/dts/exynos5440.dtsi > index 871ebad..b08449e 100644 > --- a/arch/arm/boot/dts/exynos5440.dtsi > +++ b/arch/arm/boot/dts/exynos5440.dtsi > @@ -105,8 +105,6 @@ > compatible = "samsung,exynos4210-spi";Hmm, is there really no way to use PDMA in non-secure mode at all ? > reg = <0xD0000 0x1000>; > interrupts = <0 4 0>; > - tx-dma-channel = <&pdma0 5>; /* preliminary */ > - rx-dma-channel = <&pdma0 4>; /* preliminary */ > #address-cells = <1>; > #size-cells = <0>; > clocks = <&clock 21>, <&clock 16>; > @@ -184,28 +182,6 @@ > compatible = "arm,amba-bus"; > interrupt-parent = <&gic>; > ranges; > - > - pdma0: pdma@00121000 { > - compatible = "arm,pl330", "arm,primecell"; > - reg = <0x121000 0x1000>; > - interrupts = <0 46 0>; > - clocks = <&clock 8>; > - clock-names = "apb_pclk"; > - #dma-cells = <1>; > - #dma-channels = <8>; > - #dma-requests = <32>; > - }; > - > - pdma1: pdma@00120000 { > - compatible = "arm,pl330", "arm,primecell"; > - reg = <0x120000 0x1000>; > - interrupts = <0 47 0>; > - clocks = <&clock 8>; > - clock-names = "apb_pclk"; > - #dma-cells = <1>; > - #dma-channels = <8>; > - #dma-requests = <32>; > - }; > }; From mboxrd@z Thu Jan 1 00:00:00 1970 From: s.nawrocki@samsung.com (Sylwester Nawrocki) Date: Tue, 11 Jun 2013 10:49:33 +0200 Subject: [PATCH] ARM: dts: Removing pdma for SSDK5440 In-Reply-To: <109601ce6679$fef2e410$fcd8ac30$%kim@samsung.com> References: <109601ce6679$fef2e410$fcd8ac30$%kim@samsung.com> Message-ID: <51B6E49D.7000408@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 06/11/2013 10:02 AM, Kukjin Kim wrote: > From: Giridhar Maruthy > > Since the pdma works only in secure mode, accessing the same > in hypervisor mode gives an abort. As we are not using pdma > anywhere (including spi), removing the same. > > Signed-off-by: Giridhar Maruthy > Signed-off-by: Kukjin Kim I was wondering, wouldn't it be sufficient to add status = "disabled"; in those pdma nodes, to avoid re-adding them in future ? As for the DMA properties in the spi device nodes, they should indeed be removed, as generic DMA bindings would be used instead. Regards, Sylwester > --- > arch/arm/boot/dts/exynos5440.dtsi | 24 ------------------------ > 1 file changed, 24 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5440.dtsi b/arch/arm/boot/dts/exynos5440.dtsi > index 871ebad..b08449e 100644 > --- a/arch/arm/boot/dts/exynos5440.dtsi > +++ b/arch/arm/boot/dts/exynos5440.dtsi > @@ -105,8 +105,6 @@ > compatible = "samsung,exynos4210-spi";Hmm, is there really no way to use PDMA in non-secure mode at all ? > reg = <0xD0000 0x1000>; > interrupts = <0 4 0>; > - tx-dma-channel = <&pdma0 5>; /* preliminary */ > - rx-dma-channel = <&pdma0 4>; /* preliminary */ > #address-cells = <1>; > #size-cells = <0>; > clocks = <&clock 21>, <&clock 16>; > @@ -184,28 +182,6 @@ > compatible = "arm,amba-bus"; > interrupt-parent = <&gic>; > ranges; > - > - pdma0: pdma at 00121000 { > - compatible = "arm,pl330", "arm,primecell"; > - reg = <0x121000 0x1000>; > - interrupts = <0 46 0>; > - clocks = <&clock 8>; > - clock-names = "apb_pclk"; > - #dma-cells = <1>; > - #dma-channels = <8>; > - #dma-requests = <32>; > - }; > - > - pdma1: pdma at 00120000 { > - compatible = "arm,pl330", "arm,primecell"; > - reg = <0x120000 0x1000>; > - interrupts = <0 47 0>; > - clocks = <&clock 8>; > - clock-names = "apb_pclk"; > - #dma-cells = <1>; > - #dma-channels = <8>; > - #dma-requests = <32>; > - }; > };